Helm: Only insert nodePort for cilium-ingress-service if specified#41107
Merged
gandro merged 1 commit intocilium:mainfrom Aug 19, 2025
Merged
Helm: Only insert nodePort for cilium-ingress-service if specified#41107gandro merged 1 commit intocilium:mainfrom
gandro merged 1 commit intocilium:mainfrom
Conversation
gandro
approved these changes
Aug 13, 2025
Member
|
/test |
Member
|
CI is failing because the branch is very old and there's a discrepancy between the tests and the tested code. Unfortunately I don't have permissions to rebase it myself. @baurmatt could you rebase on current |
This is needed for ArgoCD deployments overwise the app will stay in OutOfSync status. Signed-off-by: Matthias Baur <m.baur@syseleven.de>
auto-merge was automatically disabled
August 19, 2025 08:22
Head branch was pushed to by a user without write access
d47ea7d to
ea71d88
Compare
Member
|
/test |
Contributor
Author
|
@baurmatt Doesn't seem to help :( Kind of doubt that the broken CI is related to my change 🙈 |
Member
|
The failures are different now - they look still unrelated though, I'll restart. |
LiquidPL
added a commit
to LiquidPL/infra
that referenced
this pull request
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for ArgoCD deployments overwise the app will stay in OutOfSync status.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #issue-number