Skip to content

cli,docs/ipsec: Sequence number is on 64bits#40622

Merged
aanm merged 1 commit intomainfrom
pr/pchaigno/ipsec-cli-64b-seq-number
Jul 25, 2025
Merged

cli,docs/ipsec: Sequence number is on 64bits#40622
aanm merged 1 commit intomainfrom
pr/pchaigno/ipsec-cli-64b-seq-number

Conversation

@pchaigno
Copy link
Copy Markdown
Member

@pchaigno pchaigno commented Jul 21, 2025

Since v1.18, IPsec sequence numbers are always on 64bits. When reporting the maximum sequence number on a node or cluster, we should therefore display it as "X/0xffffffffffffffff". Otherwise some users may be confused when they reach the 32bit maximum and keep going.

Fix bug where we would display the Max Seq. Number for IPsec on 32bits.

@pchaigno pchaigno added release-note/bug This PR fixes an issue in a previous release of Cilium. feature/ipsec Relates to Cilium's IPsec feature needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Jul 21, 2025
@github-actions github-actions bot added the cilium-cli This PR contains changes related with cilium-cli label Jul 21, 2025
@pchaigno pchaigno force-pushed the pr/pchaigno/ipsec-cli-64b-seq-number branch 2 times, most recently from 30e8c46 to 17de267 Compare July 21, 2025 15:02
Since v1.18, IPsec sequence numbers are always on 64bits. When reporting
the maximum sequence number on a node or cluster, we should therefore
display it as "X/0xffffffffffffffff". Otherwise some users may be
confused when they reach the 32bit maximum and keep going.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the pr/pchaigno/ipsec-cli-64b-seq-number branch from 17de267 to 6a830ea Compare July 22, 2025 10:19
@pchaigno
Copy link
Copy Markdown
Member Author

/test

@pchaigno pchaigno marked this pull request as ready for review July 22, 2025 10:51
@pchaigno pchaigno requested review from a team as code owners July 22, 2025 10:51
@pchaigno pchaigno requested review from asauber, qmonnet and rgo3 July 22, 2025 10:51
@pchaigno pchaigno enabled auto-merge July 22, 2025 12:51
@aanm aanm disabled auto-merge July 25, 2025 11:52
@aanm aanm merged commit 7144c9b into main Jul 25, 2025
333 of 338 checks passed
@aanm aanm deleted the pr/pchaigno/ipsec-cli-64b-seq-number branch July 25, 2025 11:52
@rastislavs rastislavs mentioned this pull request Jul 28, 2025
2 tasks
@rastislavs rastislavs added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Jul 28, 2025
@github-actions github-actions bot added backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Jul 28, 2025
zocimek added a commit to zocimek/home-ops that referenced this pull request Aug 25, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[aqua:cilium/cilium-cli](https://redirect.github.com/cilium/cilium-cli)
| patch | `0.18.5` -> `0.18.6` |

---

### Release Notes

<details>
<summary>cilium/cilium-cli (aqua:cilium/cilium-cli)</summary>

###
[`v0.18.6`](https://redirect.github.com/cilium/cilium-cli/releases/tag/v0.18.6)

[Compare
Source](https://redirect.github.com/cilium/cilium-cli/compare/v0.18.5...v0.18.6)

#### What's Changed

**Minor Changes:**

- Cilium uninstall now removes annotations from Kubernetes nodes when
clean-cilium-state: true
([cilium/cilium#39931](https://redirect.github.com/cilium/cilium/issues/39931),
[@&#8203;AritraDey-Dev](https://redirect.github.com/AritraDey-Dev))
- Deprecate `v2alpha1` version of `CiliumLoadBalancerIPPool` CRD in
favor of the `v2` version
([cilium/cilium#39134](https://redirect.github.com/cilium/cilium/issues/39134),
[@&#8203;pippolo84](https://redirect.github.com/pippolo84))

**Bugfixes:**

- Fix bug where we would display the Max Seq. Number for IPsec on
32bits.
([cilium/cilium#40622](https://redirect.github.com/cilium/cilium/issues/40622),
[@&#8203;pchaigno](https://redirect.github.com/pchaigno))

**CI Changes:**

- Add l7 proxy check for `to-fqdns` connectivity test
([cilium/cilium#40549](https://redirect.github.com/cilium/cilium/issues/40549),
[@&#8203;vipul-21](https://redirect.github.com/vipul-21))
- cli: switch coredns image to registry.k8s.io, and fix renovate
([cilium/cilium#40706](https://redirect.github.com/cilium/cilium/issues/40706),
[@&#8203;giorio94](https://redirect.github.com/giorio94))
- connectivity: Allow customization of tcpdump kill timeout
([cilium/cilium#40774](https://redirect.github.com/cilium/cilium/issues/40774),
[@&#8203;gentoo-root](https://redirect.github.com/gentoo-root))
- connectivity: rework sniffer to execute tcpdump in background
([cilium/cilium#40487](https://redirect.github.com/cilium/cilium/issues/40487),
[@&#8203;smagnani96](https://redirect.github.com/smagnani96))

**Misc Changes:**

- chore(deps): update docker.io/library/golang:1.24.4 docker digest to
[`20a022e`](https://redirect.github.com/cilium/cilium-cli/commit/20a022e)
(main)
([cilium/cilium#40379](https://redirect.github.com/cilium/cilium/issues/40379),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update docker.io/library/golang:1.24.5 docker digest to
[`ef5b4be`](https://redirect.github.com/cilium/cilium-cli/commit/ef5b4be)
(main)
([cilium/cilium#40738](https://redirect.github.com/cilium/cilium/issues/40738),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update go to v1.24.5 (main)
([cilium/cilium#40496](https://redirect.github.com/cilium/cilium/issues/40496),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- cilium-cli: Print partial output upon `bgp peers` errors
([cilium/cilium#40278](https://redirect.github.com/cilium/cilium/issues/40278),
[@&#8203;rastislavs](https://redirect.github.com/rastislavs))
- cilium-cli: Update default network-perf image
([cilium/cilium#40376](https://redirect.github.com/cilium/cilium/issues/40376),
[@&#8203;HadrienPatte](https://redirect.github.com/HadrienPatte))
- cilium-cli: Use slim k8s packages for connectivity tests
([cilium/cilium#40708](https://redirect.github.com/cilium/cilium/issues/40708),
[@&#8203;HadrienPatte](https://redirect.github.com/HadrienPatte))
- Fix misc typos
([cilium/cilium#40769](https://redirect.github.com/cilium/cilium/issues/40769),
[@&#8203;HadrienPatte](https://redirect.github.com/HadrienPatte))
- go.mod, vendor: pull in charts for Cilium 1.18.0 and Tetragon 1.5.0
([cilium/cilium#40823](https://redirect.github.com/cilium/cilium/issues/40823),
[@&#8203;tklauser](https://redirect.github.com/tklauser))
- Miscellaneous improvements to option.NewNamedMapOptions
([cilium/cilium#40529](https://redirect.github.com/cilium/cilium/issues/40529),
[@&#8203;giorio94](https://redirect.github.com/giorio94))
- The unableTranslateCIDRgroups variable is removed as it is not used
since the v1.17 release
([cilium/cilium#40267](https://redirect.github.com/cilium/cilium/issues/40267),
[@&#8203;Surya-7890](https://redirect.github.com/Surya-7890))
- vendor: Update github.com/google/go-github to v73
([cilium/cilium#40326](https://redirect.github.com/cilium/cilium/issues/40326),
[@&#8203;HadrienPatte](https://redirect.github.com/HadrienPatte))
- Update stable release to v0.18.5 by
[@&#8203;tklauser](https://redirect.github.com/tklauser) in
[https://github.com/cilium/cilium-cli/pull/3060](https://redirect.github.com/cilium/cilium-cli/pull/3060)
- chore(deps): update docker.io/library/golang:1.24.4 docker digest to
[`20a022e`](https://redirect.github.com/cilium/cilium-cli/commit/20a022e)
by [@&#8203;renovate](https://redirect.github.com/renovate)\[bot]
in[https://github.com/cilium/cilium-cli/pull/3061](https://redirect.github.com/cilium/cilium-cli/pull/3061)1
- Update RELEASE.md by
[@&#8203;michi-covalent](https://redirect.github.com/michi-covalent) in
[https://github.com/cilium/cilium-cli/pull/3062](https://redirect.github.com/cilium/cilium-cli/pull/3062)
- chore(deps): update golang docker tag to v1.24.5 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot]
in[https://github.com/cilium/cilium-cli/pull/3063](https://redirect.github.com/cilium/cilium-cli/pull/3063)3
- chore(deps): update go to v1.24.5 (patch) by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot]
in[https://github.com/cilium/cilium-cli/pull/3065](https://redirect.github.com/cilium/cilium-cli/pull/3065)5
- chore(deps): update golangci/golangci-lint docker tag to v2.2.2 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot]
in[https://github.com/cilium/cilium-cli/pull/3066](https://redirect.github.com/cilium/cilium-cli/pull/3066)6
- chore(deps): update dependency cilium/cilium to v1.17.6 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot]
in[https://github.com/cilium/cilium-cli/pull/3068](https://redirect.github.com/cilium/cilium-cli/pull/3068)8
- chore(deps): update golang:1.24.5-alpine3.21 docker digest to
[`3ebc008`](https://redirect.github.com/cilium/cilium-cli/commit/3ebc008)
by [@&#8203;renovate](https://redirect.github.com/renovate)\[bot]
in[https://github.com/cilium/cilium-cli/pull/3067](https://redirect.github.com/cilium/cilium-cli/pull/3067)7
- chore(deps): update golang:1.24.5-alpine3.21 docker digest to
[`72ff633`](https://redirect.github.com/cilium/cilium-cli/commit/72ff633)
by [@&#8203;renovate](https://redirect.github.com/renovate)\[bot]
in[https://github.com/cilium/cilium-cli/pull/3069](https://redirect.github.com/cilium/cilium-cli/pull/3069)9
- chore(deps): update golang:1.24.5-alpine3.21 docker digest to
[`6edc205`](https://redirect.github.com/cilium/cilium-cli/commit/6edc205)
by [@&#8203;renovate](https://redirect.github.com/renovate)\[bot]
in[https://github.com/cilium/cilium-cli/pull/3070](https://redirect.github.com/cilium/cilium-cli/pull/3070)0
- chore(deps): update golangci/golangci-lint docker tag to v2.3.0 -
autoclosed by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot]
in[https://github.com/cilium/cilium-cli/pull/3071](https://redirect.github.com/cilium/cilium-cli/pull/3071)1
- chore(deps): update dependency cilium/cilium to v1.18.0 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot]
in[https://github.com/cilium/cilium-cli/pull/3073](https://redirect.github.com/cilium/cilium-cli/pull/3073)3
- chore(deps): update docker.io/library/golang:1.24.5 docker digest to
[`ef5b4be`](https://redirect.github.com/cilium/cilium-cli/commit/ef5b4be)
by [@&#8203;renovate](https://redirect.github.com/renovate)\[bot]
in[https://github.com/cilium/cilium-cli/pull/3072](https://redirect.github.com/cilium/cilium-cli/pull/3072)2
- Prepare for v0.18.6 release by
[@&#8203;tklauser](https://redirect.github.com/tklauser) in
[https://github.com/cilium/cilium-cli/pull/3074](https://redirect.github.com/cilium/cilium-cli/pull/3074)

**Full Changelog**:
cilium/cilium-cli@v0.18.5...v0.18.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/zocimek/home-ops).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS40My41IiwidXBkYXRlZEluVmVyIjoiNDEuNDYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Łukasz Pospiech <zocimek@users.noreply.github.com>
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. cilium-cli This PR contains changes related with cilium-cli feature/ipsec Relates to Cilium's IPsec feature release-note/bug This PR fixes an issue in a previous release of Cilium.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

6 participants