helm: add Envoy image to pre-flight#39670
Merged
aanm merged 5 commits intocilium:mainfrom Jun 17, 2025
Merged
Conversation
Contributor
Author
|
/test |
squeed
reviewed
May 26, 2025
squeed
reviewed
May 26, 2025
squeed
reviewed
May 26, 2025
squeed
reviewed
May 26, 2025
install/kubernetes/cilium/templates/cilium-preflight/daemonset.yaml
Outdated
Show resolved
Hide resolved
Contributor
|
great idea. A few nits, nothing more. (please re-request review when ready, otherwise it gets lost in the noise) |
marseel
approved these changes
May 26, 2025
Member
marseel
left a comment
There was a problem hiding this comment.
nice improvement, FYI @cilium/sig-servicemesh
squeed
approved these changes
Jun 2, 2025
Contributor
squeed
left a comment
There was a problem hiding this comment.
Looks good.
I agree with filing a follow-up PR to clean up some more of the preflight nits. Thanks!
Member
|
It looks like this PR fell through the gaps on testing, sorry. I've triggered some of the smoke tests and they've identified a few things that need to be addressed in this PR prior to merge:
Would you mind updating them, then we can run the full testsuite. |
Signed-off-by: Scott Stuart <sstuart@doximity.com>
Signed-off-by: Scott Stuart <sstuart@doximity.com>
Signed-off-by: Scott Stuart <sstuart@doximity.com>
Member
|
/test |
Signed-off-by: Scott Stuart <sstuart@doximity.com>
auto-merge was automatically disabled
June 16, 2025 23:27
Head branch was pushed to by a user without write access
Contributor
Author
|
issues should be addressed now |
Signed-off-by: Scott Stuart <sstuart@doximity.com>
aanm
approved these changes
Jun 17, 2025
Member
|
/test |
3 tasks
rabelmervin
pushed a commit
to rabelmervin/cilium
that referenced
this pull request
Aug 18, 2025
After the below PR, Cilium Envoy is part of preflight, hence the related config map is required if preflight flag is set. Relates: cilium#39670 Fixes: cilium#40805 Signed-off-by: Tam Mach <tam.mach@cilium.io>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Envoy image to the pre-flight process, so that Envoy will be pre-pulled during a Cilium upgrade.
Fixes: #39374