[v1.17] wireguard:fix: always detach unneeded programs#38184
Merged
julianwiedmann merged 2 commits intocilium:v1.17from Mar 18, 2025
Merged
[v1.17] wireguard:fix: always detach unneeded programs#38184julianwiedmann merged 2 commits intocilium:v1.17from
julianwiedmann merged 2 commits intocilium:v1.17from
Conversation
514c34e to
f2d6d7f
Compare
4 tasks
f2d6d7f to
d5247b9
Compare
Member
|
But this won't help the ci downgrade issue in #38077, because we don't have the downgrade cilium image with this patch until next 117 release? |
Contributor
Author
#38187 <- That PR will introduce the removal logic for the new cil_from_wireguard.
|
d5247b9 to
9d0b36c
Compare
[ upstream commit 71f5f12 ] This commit moves the current check whether to attach cil_to_wireguard into a specific config utility function. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
[ upstream commit 570f056 ] This commit patches our current logic to always remove the BPF programs from cilium_wg0 when not needed. Prior to this, we tend to skip the check, which could cause problems due to the fact that programs are not unloaded. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
9d0b36c to
ef540ca
Compare
Contributor
Author
|
/test |
rgo3
approved these changes
Mar 18, 2025
julianwiedmann
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport for #38179.
Once this PR is merged, a GitHub action will update the labels of these PRs: