wireguard:fix: always detach unneeded programs#38179
Merged
julianwiedmann merged 2 commits intocilium:mainfrom Mar 17, 2025
Merged
wireguard:fix: always detach unneeded programs#38179julianwiedmann merged 2 commits intocilium:mainfrom
julianwiedmann merged 2 commits intocilium:mainfrom
Conversation
This commit moves the current check whether to attach cil_to_wireguard into a specific config utility function. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
34d9933 to
58883a3
Compare
4 tasks
58883a3 to
ed7dd43
Compare
jschwinger233
approved these changes
Mar 14, 2025
rgo3
reviewed
Mar 14, 2025
This commit patches our current logic to always remove the BPF programs from cilium_wg0 when not needed. Prior to this, we tend to skip the check, which could cause problems due to the fact that programs are not unloaded. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
ed7dd43 to
ee1f3a1
Compare
Contributor
Author
|
/test |
rgo3
approved these changes
Mar 14, 2025
Contributor
rgo3
left a comment
There was a problem hiding this comment.
LGTM, thanks. This should be back-portable to 1.17 without any additional manual work correct?
Contributor
Author
Correct. Backport PR (to be updated) doesn't seems to complain. |
joamaki
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, we make sure to always detach programs attached to
cilium_wg0in case they're not needed anymore:cil_from_netdevin the ingress hookcil_to_wireguardin the egress hook