pkg/ip: add functionality to coalesce CIDR list#3619
Merged
Conversation
d7496de to
a4e176c
Compare
Member
Author
|
test-me-please |
joestringer
approved these changes
Apr 10, 2018
Member
joestringer
left a comment
There was a problem hiding this comment.
Minor comment, nothing blocking. I expect to start using this library soon, after which point I may be able to provide some better feedback as a user. Either way, the testing looks good and I expect that there will be users in the codebase before too long so it seems reasonable to merge in its current state.
Member
There was a problem hiding this comment.
I assume this is making use of the RFC2765 IPv4-mapped address prefix? Would be nice to have a brief comment mentioning this, and perhaps naming the variable as v4Mappedv6Prefix
Member
Author
There was a problem hiding this comment.
Fixed in latest update.
20 tasks
Add CoalesceCIDRs and associated helper functions, which combines a list of CIDRs into the smallest equivalent set of CIDRs. Signed-off by: Ian Vernon <ian@cilium.io>
a4e176c to
2705a5e
Compare
Member
Author
|
test-me-please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CoalesceCIDRs and associated helper functions, which combines a list of
CIDRs into the smallest equivalent set of CIDRs.
Signed-off by: Ian Vernon ian@cilium.io
This was long-lived in a previous PR, but I wanted to separate the library code being merged from the actual consumption of the code in Cilium.
Partially address #1658 : this is only the library functionality. Cilium can consume this change at a later time (this is tracked as part of #1658).