Test: Checks for deadlocks panics in logs per each test.#3211
Merged
raybejjani merged 1 commit intocilium:masterfrom Mar 21, 2018
Merged
Test: Checks for deadlocks panics in logs per each test.#3211raybejjani merged 1 commit intocilium:masterfrom
raybejjani merged 1 commit intocilium:masterfrom
Conversation
Member
Author
|
test-me-please |
This commit make sure that there is no panic or deadlocks in cilium logs after executed the test. The test uses `CurrentGinkgoTestDescription().Duration` to know the current duration of the test, so the helper only search in the logs files since test starts. (In case of any panic in log, it'll not mark all test as failed) The panic string example is: ``` Mar 15 16:35:50 runtime cilium-agent[8220]: panic: runtime error: invalid memory address or nil pointer dereference Mar 15 16:35:50 runtime cilium-agent[8220]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x2 pc=0x17e3b2c] Mar 15 16:35:50 runtime cilium-agent[8220]: goroutine 58384 [running]: ``` The deadlock string example is: ``` Jan 03 00:40:09 cilium-master cilium-agent[32439]: POTENTIAL DEADLOCK: Jan 03 00:40:09 cilium-master cilium-agent[32439]: Previous place where the lock was grabbed Jan 03 00:40:09 cilium-master cilium-agent[32439]: goroutine 8974 lock 0xc4201b875c ``` Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
Member
Author
|
test-me-please |
1 similar comment
Member
Author
|
test-me-please |
ianvernon
approved these changes
Mar 20, 2018
Member
ianvernon
left a comment
There was a problem hiding this comment.
Looks great overall, just some minor doc fixes needed, so no need to re-ask for review again once you have fixed them. Thanks for doing this! One comment -in the future, please have vendor updates as separate commits.
| } | ||
|
|
||
| // ValidateNoErrorsOnLogs checks in cilium logs since the given duration (By | ||
| // default `CurrentGinkgoTestDescription().Duration`) that no `panic` messages |
Member
There was a problem hiding this comment.
... checks that the cilium logs ... do not contain panic or deadlock messages.
|
|
||
| } | ||
|
|
||
| // ValidateNoErrorsOnLogs checks in cilium logs since the given duration (By |
Member
There was a problem hiding this comment.
... checks that the cilium logs ... do not contain panic or deadlock messages.
raybejjani
approved these changes
Mar 21, 2018
Contributor
|
oh, crap. I merged this without waiting for the changes ian asked for. @eloycoto could you make another PR for that and I'll merge it in. sorry |
Member
|
@raybejjani no worries! Nothing was blocking on my review. |
eloycoto
added a commit
to eloycoto/cilium
that referenced
this pull request
Mar 23, 2018
Addressed comments from PR cilium#3211 Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
tgraf
pushed a commit
that referenced
this pull request
Mar 23, 2018
Addressed comments from PR #3211 Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit make sure that there is no panic or deadlocks in cilium logs
after executed the test.
The test uses
CurrentGinkgoTestDescription().Durationto know thecurrent duration of the test, so the helper only search in the logs
files since test starts. (In case of any panic in log, it'll not mark
all test as failed)
The panic string example is:
The deadlock string example is:
Signed-off-by: Eloy Coto eloy.coto@gmail.com