hive,metrics: Add metrics for pkg/hive/job#26077
Merged
dylandreimerink merged 1 commit intocilium:mainfrom Jul 3, 2023
Merged
Conversation
4b01365 to
32a9fba
Compare
joamaki
reviewed
Jun 13, 2023
ae67055 to
d02ba53
Compare
pippolo84
reviewed
Jun 15, 2023
fc3e9fd to
6fc509e
Compare
aditighag
approved these changes
Jun 21, 2023
Member
Author
|
/test |
6fc509e to
0dcebb5
Compare
This commit adds a metric to that tracks error counts for job runs, a metric to track timer run performance and observer run performance. For one shot jobs the metric collection is disabled by default, only jobs with the `WithMetrics` option will be measured. This way we can collect metrics for short running jobs and skip collection for high cardinality jobs or jobs that run forever. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
0dcebb5 to
e056d7a
Compare
Member
Author
|
/test |
mhofstetter
added a commit
to mhofstetter/cilium
that referenced
this pull request
Dec 15, 2025
This commit updates the documentation about hive job metrics. * Initially introduced and documented with cilium#26077 * Deleted when cilium/hive has been extracted with cilium#32020 * Re-introduced via integration with cilium#42762 (not aware that they existed in the past) Therefore this commit updates the docs to reflect the current implementation. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
This commit updates the documentation about hive job metrics. * Initially introduced and documented with #26077 * Deleted when cilium/hive has been extracted with #32020 * Re-introduced via integration with #42762 (not aware that they existed in the past) Therefore this commit updates the docs to reflect the current implementation. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a metric to that tracks error counts for job runs, a metric to track timer run performance and observer run performance.
For one shot jobs the metric collection is disabled by default, only jobs with the
WithMetricsoption will be measured. This way we can collect metrics for short running jobs and skip collection for high cardinality jobs or jobs that run forever.