Conversation
There was a problem hiding this comment.
exported method Cilium.PolicyGetAll should have comment or be unexported
There was a problem hiding this comment.
exported method Cilium.PolicyDelAll should have comment or be unexported
There was a problem hiding this comment.
comment on exported const IPv4 should be of the form "IPv4 ..."
There was a problem hiding this comment.
comment on exported const Create should be of the form "Create ..."
There was a problem hiding this comment.
comment on exported const Httpd1 should be of the form "Httpd1 ..."
There was a problem hiding this comment.
exported method CmdRes.GetStdErr should have comment or be unexported
There was a problem hiding this comment.
exported method CmdRes.GetStdOut should have comment or be unexported
There was a problem hiding this comment.
exported type PerfTest should have comment or be unexported
There was a problem hiding this comment.
comment on exported function CurlFail should be of the form "CurlFail ..."
There was a problem hiding this comment.
don't use ALL_CAPS in Go names; use CamelCase
There was a problem hiding this comment.
exported method Cilium.PolicyGetAll should have comment or be unexported
There was a problem hiding this comment.
exported method Cilium.PolicyDelAll should have comment or be unexported
There was a problem hiding this comment.
comment on exported const IPv4 should be of the form "IPv4 ..."
There was a problem hiding this comment.
comment on exported const Create should be of the form "Create ..."
There was a problem hiding this comment.
comment on exported const Httpd1 should be of the form "Httpd1 ..."
There was a problem hiding this comment.
exported method CmdRes.GetStdErr should have comment or be unexported
There was a problem hiding this comment.
exported method CmdRes.GetStdOut should have comment or be unexported
There was a problem hiding this comment.
exported type PerfTest should have comment or be unexported
There was a problem hiding this comment.
comment on exported function CurlFail should be of the form "CurlFail ..."
There was a problem hiding this comment.
don't use ALL_CAPS in Go names; use CamelCase
There was a problem hiding this comment.
exported const MonitorDropNotification should have comment (or a comment on this block) or be unexported
There was a problem hiding this comment.
don't use ALL_CAPS in Go names; use CamelCase
exported const TCP_RR should have comment (or a comment on this block) or be unexported
There was a problem hiding this comment.
exported const MonitorDropNotification should have comment (or a comment on this block) or be unexported
There was a problem hiding this comment.
don't use ALL_CAPS in Go names; use CamelCase
exported const TCP_RR should have comment (or a comment on this block) or be unexported
Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
Not all runtime tests are prefixed with "Runtime" in their Describe block. Change the Jenkinsfile to run these tests. Signed-off by: Ian Vernon <ian@cilium.io>
There are some scripts that we still need to run as part of the Ginkgo tests. Migrate these scripts to be under the directory. Make sure that these tests are ran as part of the Makefile targets used in the Ginkgo tests. Signed-off by: Ian Vernon <ian@cilium.io>
The way that unit tests are ran in the Ginkgo tests need to have GOROOT and GOPATH set. Set these variables in the developer Docker image. Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
Add a variety of constants for use in tests to significantly reduce the amount of hardcoding. Signed-off by: Ian Vernon <ian@cilium.io>
* Utilize constants added in test/helpers/cons.go * Add `gops` use for getting stack traces in case the Ginkgo tests deadlock. * Miscellaneous cleanup / log message changes. Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
* Use constants recently added in `test/helpers/cons.go` to reduce amount of hardcoding. * Refactor Node structure to be more aptly-named to SSHMeta. * Add wrappers around commonly used testing commands (ping, curl, netperf). Signed-off by: Ian Vernon <ian@cilium.io>
* Use constants recently added in `test/helpers/cons.go` * Miscellaneous log message cleanup. Signed-off by: Ian Vernon <ian@cilium.io>
* Use constants recently added in `test/helpers/cons.go`. * Miscellaneous log message changes and cleanup. Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
* Add ReportFailed() function call if any It() fails * Wait until endpoints are ready before running chaos testing * Change expect output to compare strings instead of hard-to-read byte buffers Signed-off by: Ian Vernon <ian@cilium.io>
* Start cilium-etcd service when running on new VM image for etcd tests to succeed. * Dump output of spawned cilium process if it isn't ready for easier debugging. Signed-off by: Ian Vernon <ian@cilium.io>
* Change iptables FORWARD to default ACCEPT * Change default pod CIDR Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
Signed-off by: Ian Vernon <ian@cilium.io>
1b8e281 to
7265941
Compare
| var EndpointWaitUntilReadyRetry int = 0 //List how many retries EndpointWaitUntilReady should have | ||
|
|
||
| //EndpointWaitUntilReady This function wait until all the endpoints are in the ready status | ||
| func (c *Cilium) WaitEndpointGeneration() bool { |
There was a problem hiding this comment.
exported method Cilium.WaitEndpointGeneration should have comment or be unexported
|
|
||
| const ( | ||
| MaxRetries = 30 | ||
| MaxRetries = 120 |
There was a problem hiding this comment.
exported const MaxRetries should have comment (or a comment on this block) or be unexported
| ) | ||
|
|
||
| const ( | ||
| BasePath = "/home/vagrant/go/src/github.com/cilium/cilium/test" |
There was a problem hiding this comment.
exported const BasePath should have comment (or a comment on this block) or be unexported
|
Closing in favor of smaller, more managable PRs. |
[ cherry-picked from cilium/cilium-cli repository ] Renovate added this replace directive in #1733, and now #2041 doesn't compile because it needs a newer version of github.com/docker/docker. Let's remove this replace directive and hope everything works out. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
[ cherry-picked from cilium/cilium-cli repository ] Renovate added this replace directive in #1733, and now #2041 doesn't compile because it needs a newer version of github.com/docker/docker. Let's remove this replace directive and hope everything works out. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
WIP, do not review yet!