operator: Move CRD registration to operator#13285
Merged
aanm merged 5 commits intocilium:masterfrom Sep 29, 2020
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
12 tasks
christarazi
commented
Sep 24, 2020
e164c9b to
23c3578
Compare
76ee1bb to
ba96c7b
Compare
Member
Author
|
test-me-please |
aanm
requested changes
Sep 25, 2020
Member
aanm
left a comment
There was a problem hiding this comment.
One other item missing. There is, all over the operator code, check methods waiting for a CRD to be available. This should no longer be required and can be removed as part of these changes.
sayboras
reviewed
Sep 25, 2020
vadorovsky
suggested changes
Sep 25, 2020
14fdb72 to
55c0cc4
Compare
This comment has been minimized.
This comment has been minimized.
55c0cc4 to
cab6aeb
Compare
This comment has been minimized.
This comment has been minimized.
cab6aeb to
f1e3d79
Compare
e400b62 to
5648a35
Compare
This comment has been minimized.
This comment has been minimized.
5648a35 to
26d484e
Compare
Member
Author
|
test-me-please |
aanm
requested changes
Sep 26, 2020
7 tasks
d0066a1 to
73ca4bb
Compare
Member
Author
|
test-me-please |
Member
Author
|
test-gke |
aanm
approved these changes
Sep 28, 2020
Member
aanm
left a comment
There was a problem hiding this comment.
One small TODO doesn't require my follow up review
73ca4bb to
488f414
Compare
This commit deprecates the permissions for CRD operations and marks them for removal in v1.10 from the agent. Additionally, this commit grants them to cilium-operator. This commit is a preparatory for a future commit to move the CRD operations to the cilium-operator. Signed-off-by: Chris Tarazi <chris@isovalent.com>
This commit reverts the following two commits, along with the vendored changes that are no longer needed. The rationale is that we no longer need cilium-operator to wait for CRDs as cilium-operator will now register the CRDs (in a future commit), previously done by the agent. --- Commit 5dbe413 ("operator: Make CRD availability timeout configurable") was selectively reverted, only keeping the declarations of the crd-wait-timeout flag, so that they can be deprecated in a future commit. --- Revert "operator: Wait for CRDs before running informers" This reverts commit 8e4f348. Signed-off-by: Chris Tarazi <chris@isovalent.com>
This commit deprecates the crd-wait-timeout option as the functionality has been removed in the previous commit. This option will be removed in 1.10. This commit also updates the cmdref accordingly. Signed-off-by: Chris Tarazi <chris@isovalent.com>
This commit is mostly a refactoring change to ease future commits. It also removes a duplicated `Update()` call which is already done in `Init()`. Signed-off-by: Chris Tarazi <chris@isovalent.com>
In pursuit of delegating all cluster operations to cilium-operator from the agent, this commit moves the CRD registration under the purview of cilium-operator. Signed-off-by: Chris Tarazi <chris@isovalent.com>
488f414 to
7de2be6
Compare
Member
Author
|
test-me-please |
vadorovsky
approved these changes
Sep 29, 2020
christarazi
added a commit
to christarazi/cilium
that referenced
this pull request
Dec 16, 2021
Following up on cilium#13285. Signed-off-by: Chris Tarazi <chris@isovalent.com>
tklauser
pushed a commit
that referenced
this pull request
Dec 21, 2021
Following up on #13285. Signed-off-by: Chris Tarazi <chris@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
This PR is the final piece to move the CRD registration responsibilities to cilium-operator. In the case of new CRDs, an upcoming PR will install the CRDs via Helm. In the case of upgrades, cilium-operator will handle the upgrades if Helm does not upgrade them. This will ensure that we are always running the most up-to-date CRDs.
See commit msgs.
Updates: #12737