Skip to content

Remove DNS poller#13229

Merged
qmonnet merged 4 commits intomasterfrom
pr/tklauser/remove-dns-poller
Sep 22, 2020
Merged

Remove DNS poller#13229
qmonnet merged 4 commits intomasterfrom
pr/tklauser/remove-dns-poller

Conversation

@tklauser
Copy link
Copy Markdown
Member

@tklauser tklauser commented Sep 21, 2020

The DNS Poller was deprecated in v1.8 by #10629 and announced to be
removed in v1.9. Remove it now.

Fixes: #8604

Remove DNS poller after being deprecated in Cilium 1.8.

@tklauser
daemon, option, test: remove DNS poller options
7c58e45 
The actual functionality will be removed in successive commits.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser
daemon, fqdn: remove DNS poller implementation
a7d8891 
The DNS Poller was deprecated in v1.8 in #10629 and announced to be
removed in v1.9. Remove it now.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser requested a review from a team September 21, 2020 09:14
@tklauser tklauser requested review from a team as code owners September 21, 2020 09:14
@tklauser tklauser requested a review from a team September 21, 2020 09:14
@tklauser tklauser requested a review from a team as a code owner September 21, 2020 09:14
@maintainer-s-little-helper maintainer-s-little-helper Bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 21, 2020
@tklauser tklauser added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Sep 21, 2020
@maintainer-s-little-helper maintainer-s-little-helper Bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 21, 2020
@tklauser
Copy link
Copy Markdown
Member Author

tklauser commented Sep 21, 2020

test-me-please

@tklauser
test: fix runtime tests after removal of DNS poller
ba9e30c 
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser
proxy/accesslog: remove DNSSourceAgentPoller
62d5231 
This DNS data source type is no longer used after the DNS poller was
removed. Remove it as well.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/tklauser/remove-dns-poller branch from 7692713 to 62d5231 Compare September 21, 2020 13:17
@tklauser
Copy link
Copy Markdown
Member Author

tklauser commented Sep 21, 2020

test-focus RuntimeFQDN*

@tklauser
Copy link
Copy Markdown
Member Author

tklauser commented Sep 21, 2020

test-me-please

@tklauser
Copy link
Copy Markdown
Member Author

tklauser commented Sep 21, 2020 •
edited
Loading

retest-net-next

EDIT: hit #13224 https://jenkins.cilium.io/job/Cilium-PR-K8s-1.12-net-next/530/

@tklauser tklauser mentioned this pull request Sep 21, 2020
Closed
@maintainer-s-little-helper maintainer-s-little-helper Bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 22, 2020
@qmonnet qmonnet merged commit 029e750 into master Sep 22, 2020
@qmonnet qmonnet deleted the pr/tklauser/remove-dns-poller branch September 22, 2020 08:04
@tklauser tklauser mentioned this pull request Sep 22, 2020
Merged
tklauser added a commit that referenced this pull request Oct 2, 2020
@tklauser
test: update runtime test descriptions after removal of DNS poller
4ca0c13 
Follow-up for #13229

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser mentioned this pull request Oct 2, 2020
Merged
aanm pushed a commit that referenced this pull request Oct 5, 2020
@tklauser @aanm
test: update runtime test descriptions after removal of DNS poller
31c3bab 
Follow-up for #13229

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@joestringer joestringer mentioned this pull request Oct 12, 2020
Merged
tklauser added a commit that referenced this pull request Oct 13, 2020
@tklauser
fqdn: remove remnants godoc comments mentioning DNS poller
d191c14 
Follow-up for #13229 which removed the DNS poller implementation.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser mentioned this pull request Oct 13, 2020
Merged
aanm pushed a commit that referenced this pull request Oct 13, 2020
@tklauser @aanm
fqdn: remove remnants godoc comments mentioning DNS poller
0d4c4b6 
Follow-up for #13229 which removed the DNS poller implementation.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser added a commit that referenced this pull request Jan 12, 2021
@tklauser
api: remove unused DNSPollNames property
c2e77cd 
Support for DNS poller was removed in PR #13229 and the field is no
longer set since commit 5590bf4 ("fqdn: remove unused
(*NameManager).GetDNSNames and related fields"). Remove it before we
eventually declare the API stable.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser mentioned this pull request Jan 12, 2021
Merged
aanm pushed a commit that referenced this pull request Jan 14, 2021
@tklauser @aanm
api: remove unused DNSPollNames property
14bb372 
Support for DNS poller was removed in PR #13229 and the field is no
longer set since commit 5590bf4 ("fqdn: remove unused
(*NameManager).GetDNSNames and related fields"). Remove it before we
eventually declare the API stable.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
JacobHenner added a commit to JacobHenner/cilium that referenced this pull request Dec 18, 2024
@JacobHenner
Remove reference to DNS polling
4029796 
DNS polling was deprecated in v1.8 (cilium#8604) and
removed in v1.9 (cilium#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
@JacobHenner JacobHenner mentioned this pull request Dec 18, 2024
Merged
8 tasks
github-merge-queue Bot pushed a commit that referenced this pull request Dec 18, 2024
@JacobHenner @tklauser
Remove reference to DNS polling
ec4b782 
DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
sayboras pushed a commit that referenced this pull request Dec 19, 2024
@JacobHenner @sayboras
Remove reference to DNS polling
6e8f04f 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras pushed a commit that referenced this pull request Dec 20, 2024
@JacobHenner @sayboras
Remove reference to DNS polling
6e2a184 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue Bot pushed a commit that referenced this pull request Dec 23, 2024
@JacobHenner @sayboras
Remove reference to DNS polling
ee0d998 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras pushed a commit that referenced this pull request Dec 24, 2024
@JacobHenner @sayboras
Remove reference to DNS polling
eec2e67 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras pushed a commit that referenced this pull request Dec 25, 2024
@JacobHenner @sayboras
Remove reference to DNS polling
95fc670 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras pushed a commit that referenced this pull request Jan 7, 2025
@JacobHenner @sayboras
Remove reference to DNS polling
806ea1a 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
viktor-kurchenko pushed a commit that referenced this pull request Jan 7, 2025
@JacobHenner @viktor-kurchenko
Remove reference to DNS polling
66b7b53 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
viktor-kurchenko pushed a commit that referenced this pull request Jan 7, 2025
@JacobHenner @viktor-kurchenko
Remove reference to DNS polling
08cfea5 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
sayboras pushed a commit that referenced this pull request Jan 8, 2025
@JacobHenner @sayboras
Remove reference to DNS polling
1d836e7 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras pushed a commit that referenced this pull request Jan 9, 2025
@JacobHenner @sayboras
Remove reference to DNS polling
131da2e 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
viktor-kurchenko pushed a commit that referenced this pull request Jan 9, 2025
@JacobHenner @viktor-kurchenko
Remove reference to DNS polling
3dfd4ac 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
gentoo-root pushed a commit that referenced this pull request Jan 9, 2025
@JacobHenner @gentoo-root
Remove reference to DNS polling
e144085 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
gentoo-root pushed a commit that referenced this pull request Jan 10, 2025
@JacobHenner @gentoo-root
Remove reference to DNS polling
79ea51f 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
joestringer pushed a commit that referenced this pull request Jan 13, 2025
@JacobHenner @joestringer
Remove reference to DNS polling
c88437a 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
github-merge-queue Bot pushed a commit that referenced this pull request Jan 15, 2025
@JacobHenner @joamaki
Remove reference to DNS polling
c5a65fa 
[ upstream commit ec4b782 ]

DNS polling was deprecated in v1.8 (#8604) and
removed in v1.9 (#13229).

Signed-off-by: Jacob Henner <code@ventricle.us>
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gandro gandro gandro approved these changes

@kaworu kaworu kaworu approved these changes

@aanm aanm aanm approved these changes

+1 more reviewer

@ianvernon ianvernon ianvernon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate DNS Poller in v1.8, remove in v1.9

6 participants

@tklauser @gandro @kaworu @ianvernon @aanm @qmonnet