install/kubernetes: remove deprecated tofqdns-enable-poller option#12618
Merged
christarazi merged 1 commit intomasterfrom Jul 22, 2020
Merged
Conversation
The DNS poller was deprecated in the 1.8 release and all documentation on how to configure it should have been removed as per [1] [1] #10629 (review) However, the respective helm option (which disables the DNS poller by default) wasn't removed. Do so now. Related: #8604 Fixes: b8971ff ("Deprecate DNS Poller in v1.8") Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
rolinh
approved these changes
Jul 22, 2020
christarazi
approved these changes
Jul 22, 2020
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Jul 25, 2020
* Drop unused option cilium/cilium#12618
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DNS poller was deprecated in the 1.8 release and all documentation
on how to configure it should have been removed as per [1]
[1] #10629 (review)
However, the respective helm option (which disables the DNS poller by
default) wasn't removed. Do so now.
Related: #8604
Fixes: b8971ff ("Deprecate DNS Poller in v1.8")