Skip to content

k8s,node: Fix init of labels with Operator IPAM#12573

Merged
qmonnet merged 1 commit intomasterfrom
pr/pchaigno/fix-node-label-init-operator-ipam
Jul 20, 2020
Merged

k8s,node: Fix init of labels with Operator IPAM#12573
qmonnet merged 1 commit intomasterfrom
pr/pchaigno/fix-node-label-init-operator-ipam

Conversation

@pchaigno
Copy link
Copy Markdown
Member

@pchaigno pchaigno commented Jul 17, 2020

When using the Operator IPAM, the node labels are not properly initialized simply because the labels are not copied from K8s nodes to CiliumNode objects and vice-versa. This commit fixes it.

Fixes: #11659

Fix node label initialization with Operator IPAM

@pchaigno
k8s,node: Fix init of labels with Operator IPAM
663d0b7 
When using the Operator IPAM, the node labels are not properly
initialized simply because the labels are not copied from K8s nodes to
CiliumNode objects and vice-versa. This commit fixes it.

Fixes: a12c2ee ("k8s,node: Reuse retrieveNodeInformation to retrieve node labels")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added kind/bug This is a bug in the Cilium logic. area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.8 labels Jul 17, 2020
@pchaigno pchaigno requested a review from a team as a code owner July 17, 2020 14:16
@pchaigno pchaigno requested a review from a team July 17, 2020 14:16
@pchaigno
Copy link
Copy Markdown
Member Author

pchaigno commented Jul 17, 2020

test-me-please

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 17, 2020

Coverage Status

Coverage increased (+0.03%) to 37.018% when pulling 663d0b7 on pr/pchaigno/fix-node-label-init-operator-ipam into ba9031b on master.

christarazi
christarazi approved these changes Jul 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christarazi
Copy link
Copy Markdown
Member

christarazi commented Jul 17, 2020

retest-net-next

@pchaigno pchaigno mentioned this pull request Jul 17, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper Bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 20, 2020
@qmonnet qmonnet merged commit 9dbf00f into master Jul 20, 2020
@qmonnet qmonnet deleted the pr/pchaigno/fix-node-label-init-operator-ipam branch July 20, 2020 08:55
@pchaigno pchaigno mentioned this pull request Jul 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christarazi christarazi christarazi approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees

No one assigned

Labels

area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pchaigno @coveralls @christarazi @qmonnet