k8s,node: Reuse retrieveNodeInformation to retrieve node labels#11659
Merged
christarazi merged 2 commits intomasterfrom May 26, 2020
Merged
Conversation
3b64732 to
e3ac7a3
Compare
aanm
approved these changes
May 25, 2020
nebril
approved these changes
May 25, 2020
Member
nebril
left a comment
There was a problem hiding this comment.
one question inline, looks good otherwise
Signed-off-by: Paul Chaignon <paul@cilium.io>
e3ac7a3 to
80b6348
Compare
When creating the host endpoint, we need to retrieve existing node labels. Instead of making a new API call, we can reuse retrieveNodeInformation() to get those labels. Signed-off-by: Paul Chaignon <paul@cilium.io>
80b6348 to
b202364
Compare
Member
Author
|
test-me-please |
christarazi
approved these changes
May 26, 2020
Member
Author
|
I think this is ready to merge. I filled #11698 for the test failing on |
Member
|
Great, merging. |
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating the host endpoint, we need to retrieve existing node labels. Instead of making a new API call, we can reuse
retrieveNodeInformation()to get those labels.@tgraf In #11543, you mentioned it would be best to reuse
retrieveNodeInformation(). Is this what you had in mind?Would it be worth adding these labels to
CiliumNodeas well?