Skip to content

docs(troubleshooting): Remove bugtool related step with --serve flag#12532

Merged
qmonnet merged 1 commit intocilium:masterfrom
sayboras:docs/troubleshoot
Jul 15, 2020
Merged

docs(troubleshooting): Remove bugtool related step with --serve flag#12532
qmonnet merged 1 commit intocilium:masterfrom
sayboras:docs/troubleshoot

Conversation

@sayboras
Copy link
Copy Markdown
Member

@sayboras sayboras commented Jul 15, 2020 •
edited
Loading

The flag --serve is removed in bugtool by PR #6237, hence related docs
should be removed as well.

Signed-off-by: Tam Mach sayboras@yahoo.com

docs(troubleshooting): Remove bugtool related step with --serve flag

@sayboras sayboras requested a review from a team as a code owner July 15, 2020 13:28
@maintainer-s-little-helper maintainer-s-little-helper Bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 15, 2020
@sayboras sayboras marked this pull request as draft July 15, 2020 13:28
@sayboras sayboras force-pushed the docs/troubleshoot branch 2 times, most recently from 04d77d1 to f301a95 Compare July 15, 2020 13:31
@sayboras
docs(troubleshooting): Remove --serve flag in bugtool
5418463 
The flag --serve is removed in bugtool in PR cilium#6237, hence related docs
should be removed as well.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras sayboras force-pushed the docs/troubleshoot branch from f301a95 to 5418463 Compare July 15, 2020 13:32
@sayboras sayboras changed the title docs(troubleshooting): Remove --serve flag in bugtool docs(troubleshooting): Remove bugtool related step with --serve flag Jul 15, 2020
@sayboras sayboras marked this pull request as ready for review July 15, 2020 13:34
@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jul 15, 2020
@maintainer-s-little-helper maintainer-s-little-helper Bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 15, 2020
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 15, 2020
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 15, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 36.968% when pulling 5418463 on sayboras:docs/troubleshoot into a336059 on cilium:master.

@qmonnet qmonnet merged commit 23265dd into cilium:master Jul 15, 2020
@brb brb mentioned this pull request Jul 15, 2020
Merged
@sayboras sayboras deleted the docs/troubleshoot branch July 15, 2020 21:55
@jrfastab jrfastab mentioned this pull request Jul 21, 2020
Merged
@christarazi christarazi mentioned this pull request Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pchaigno pchaigno pchaigno approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees

No one assigned

Labels

area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sayboras @coveralls @pchaigno @qmonnet @gandro @brb @jrfastab @christarazi