Enable modification of config. for endpoints with reserved labels#12510
Enable modification of config. for endpoints with reserved labels#12510
Conversation
This comment has been minimized.
This comment has been minimized.
b43518f to
e6b1341
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...
Not sure this is consistent with the code :-) That said I suspect that you're specifically interested in allowing Taking a step back and looking at the reasoning behind the config restrictions endpoints with I don't think there's much of a security barrier question here, because even if we were to continue to disallow something like the At this point I don't think many of the original arguments really apply. Even for the health endpoint, I don't think we got to a point where it really made a difference and most likely the only folks who know about this API or regularly use it would be Cilium developers anyway. So from that perspective I'm OK with loosening these restrictions. Regarding enabling datapath debug, I think it's reasonable to locally get access to a Cilium socket and enable debug via CLI / API like this. I think if we really wanted to make this usable we'd probably support some kind of pod or node annotation that Cilium respected, but I'd guess that's more effort than it's worth for what you're trying to achieve here. |
joestringer
left a comment
There was a problem hiding this comment.
Unless you intend to make a change based upon my comment above, LGTM.
e6b1341 to
9360b76
Compare
Ouch, yes. I've updated the commit message to clarify that audit mode can also be changed.
Yes, I'd like to be able to switch the host firewall in audit mode without switching all of Cilium. There's still some work required to allow that AFAICS. In general, my approach was to only allow setting configurations that shouldn't have a huge impact on forwarding (except in case of complexity issues of course...) to prevent users from shooting themselves in the foot too easily. The audit mode is a bit of a corner case here, but as far as I can see, switching it on shouldn't result in any connectivity breakage. |
Master currently disallows users from modifying the configuration of endpoints with reserved labels, except for the reserved:init label. This restriction prevents e.g., the use of the debug mode for the host endpoint. This commit removes that restriction for some of the configuration options: Config | Default | Can modify --------------------------|----------|------------ Conntrack | Enabled | ConntrackAccounting | Enabled | ConntrackLocal | Disabled | Debug | Disabled | x DebugLB | Disabled | x DropNotification | Enabled | x MonitorAggregationLevel | None | x NAT46 | Disabled | PolicyAuditMode | Disabled | x PolicyVerdictNotification | Enabled | x TraceNotification | Enabled | x To summarize, for endpoints with reserved labels, only audit mode and configuration options that decide what logs are sent to cilium monitor can be changed for endpoints with reserved labels. Fixes: #12037 Signed-off-by: Paul Chaignon <paul@cilium.io>
This reverts commit 7cfe6f2. Signed-off-by: Paul Chaignon <paul@cilium.io>
9360b76 to
11d058a
Compare
|
test-me-please |
Master currently disallows users from modifying the configuration of endpoints with reserved labels, except for the
reserved:initlabel. This restriction prevents e.g., the use of the debug mode for the host endpoint.This commit removes that restriction for some of the configuration options:
To summarize, for endpoints with reserved labels, only audit mode and configuration options that decide what logs are sent to
cilium monitorcan be changed for endpoints with reserved labels.Fixes: #12037