Conversation
Member
Author
|
test-me-please |
…ementation The linuxNodeHandler.neighByNode map is also protected by linuxNodeHandler.mutex in all other code paths. Protect access to it in (*linuxNodeHandler).NodeValidateImplementation as well. Fixes #12460 Fixes: 6c06c51 ("node: Remove permanent ARP entry when remote node is deleted") Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
9d14a39 to
4b1cf84
Compare
Member
Author
|
test-me-please |
aanm
approved these changes
Jul 9, 2020
sayboras
reviewed
Jul 9, 2020
tklauser
added a commit
that referenced
this pull request
Jul 9, 2020
Follow-up for #12461 per review comment #12461 (comment) Suggested-by: Tam Mach <sayboras@yahoo.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
aanm
pushed a commit
that referenced
this pull request
Jul 9, 2020
Follow-up for #12461 per review comment #12461 (comment) Suggested-by: Tam Mach <sayboras@yahoo.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
brb
approved these changes
Jul 10, 2020
Member
brb
left a comment
There was a problem hiding this comment.
Thanks! I assume you have checked all other paths where nodeUpdate() is called?
Member
Author
Yes, all other code paths calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
linuxNodeHandler.neighByNodemap is also protected bylinuxNodeHandler.mutexin all other code paths. Protect access to it in`(*linuxNodeHandler).NodeValidateImplementation as well.
Fixes #12460
Fixes: 6c06c51 ("node: Remove permanent ARP entry when remote node is deleted")