Conversation
4b9152f to
bca81a0
Compare
Member
Author
|
test-me-please |
tklauser
reviewed
Jun 19, 2020
qmonnet
approved these changes
Jun 19, 2020
Member
qmonnet
left a comment
There was a problem hiding this comment.
Looks great, thanks for that.
tklauser
approved these changes
Jun 19, 2020
bca81a0 to
8a3deca
Compare
Member
Author
|
test-me-please |
joestringer
reviewed
Jun 19, 2020
aanm
requested changes
Jun 23, 2020
qmonnet
added a commit
to qmonnet/cilium
that referenced
this pull request
Jun 30, 2020
Although there is no explicit coding style for the BPF code, several
developers tend to follow the kernel coding style conventions [0]. To
try and maintain a consistent style all over the code, this commit adds
kernel's checkpatch.pl to the list of checks performed on the source as
part as BPF's "make check".
Some details on the check:
- We only run checkpatch.pl on the bpf/ directory.
- A new "checkpatch" BPF make target is created, and added as a
dependency to "check".
- However, we only run it on the latest changes by default, meaning the
changes since newest Git parent reference plus the changes returned by
"git diff HEAD".
- For manual checks, the bash script used to launch checkpatch has an
option to run the checks on all the bpf/ source code, independently of
the Git history.
- GitHub action runs checkpatch.pl on all commits from the PR. There is
no mechanism to bypass checkpatch errors, Janitors will have to decide
if issues reported by checkpatch should be ignored.
The checkpatch.pl and spelling.txt files (both under GPLv2) are directly
copied from the kernel repository, as per commit f436a58e2619
("checkpatch: fix CONST_STRUCT when const_structs.checkpatch is
missing") (in linux-next as of the creation of this patch). File
deprecated_terms.txt is created from this PR, and populated in prevision
of the changes proposed in cilium#12206. The script checkpatch.sh (bash
script) launches checkpatch.pl with the relevant arguments and options.
COPYING file is copied from bpf/COPYING, to make sure people get a
version of the license boilerplate with the checkpatch code.
[0] https://www.kernel.org/doc/html/v5.6/process/coding-style.html
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
aanm
pushed a commit
that referenced
this pull request
Jul 1, 2020
Although there is no explicit coding style for the BPF code, several
developers tend to follow the kernel coding style conventions [0]. To
try and maintain a consistent style all over the code, this commit adds
kernel's checkpatch.pl to the list of checks performed on the source as
part as BPF's "make check".
Some details on the check:
- We only run checkpatch.pl on the bpf/ directory.
- A new "checkpatch" BPF make target is created, and added as a
dependency to "check".
- However, we only run it on the latest changes by default, meaning the
changes since newest Git parent reference plus the changes returned by
"git diff HEAD".
- For manual checks, the bash script used to launch checkpatch has an
option to run the checks on all the bpf/ source code, independently of
the Git history.
- GitHub action runs checkpatch.pl on all commits from the PR. There is
no mechanism to bypass checkpatch errors, Janitors will have to decide
if issues reported by checkpatch should be ignored.
The checkpatch.pl and spelling.txt files (both under GPLv2) are directly
copied from the kernel repository, as per commit f436a58e2619
("checkpatch: fix CONST_STRUCT when const_structs.checkpatch is
missing") (in linux-next as of the creation of this patch). File
deprecated_terms.txt is created from this PR, and populated in prevision
of the changes proposed in #12206. The script checkpatch.sh (bash
script) launches checkpatch.pl with the relevant arguments and options.
COPYING file is copied from bpf/COPYING, to make sure people get a
version of the license boilerplate with the checkpatch code.
[0] https://www.kernel.org/doc/html/v5.6/process/coding-style.html
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
8a3deca to
e35c7e1
Compare
e35c7e1 to
0be845b
Compare
Member
Author
|
test-me-please |
Member
Author
|
The |
0be845b to
46ee0eb
Compare
Member
Author
|
test-me-please |
This commit replaces "svc master" by "svc frontend" and "slave" by "backend slot". Signed-off-by: Martynas Pumputis <m@lambda.lt>
Member
|
I've added the 1.8 backport flag to avoid merge conflicts from this cleanup with future fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
svc masterbysvc frontendandslavebybackend slot.