Add Hubble store getter to gain access to k8s data store.#12114
Merged
aanm merged 1 commit intocilium:masterfrom Jun 17, 2020
Merged
Add Hubble store getter to gain access to k8s data store.#12114aanm merged 1 commit intocilium:masterfrom
aanm merged 1 commit intocilium:masterfrom
Conversation
|
Please set the appropriate release note label. |
joestringer
approved these changes
Jun 16, 2020
Member
joestringer
left a comment
There was a problem hiding this comment.
LGTM at a glance, will defer to @cilium/kubernetes on whether there's any requirements around sharing the k.namespaceStore across multiple parts of the codebase.
aanm
requested changes
Jun 16, 2020
Signed-off-by: Zang Li <zangli@google.com>
aanm
approved these changes
Jun 16, 2020
Member
|
test-me-please |
|
Build finished. |
tgraf
approved these changes
Jun 17, 2020
rolinh
approved these changes
Jun 17, 2020
michi-covalent
added a commit
that referenced
this pull request
Jun 23, 2020
This is an extension to #12114 to give Hubble access to the pod store with `K8sWatcher.GetStore("pod")`. This allows Hubble to provide more context for flow data. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2020
This is an extension to #12114 to give Hubble access to the pod store with `K8sWatcher.GetStore("pod")`. This allows Hubble to provide more context for flow data. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
aanm
pushed a commit
that referenced
this pull request
Jun 26, 2020
This is an extension to #12114 to give Hubble access to the pod store with `K8sWatcher.GetStore("pod")`. This allows Hubble to provide more context for flow data. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Member
|
@lzang There seems to be no usages of this getter in the tree. Is this needed for some out of tree implementation? Would it be possible for you to rely on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zang Li zangli@google.com
Add the StoreGetter function to Hubble to get access to k8s cache store for network policy and namespace.