Merged
Conversation
This not only adds a much neded enum, but also creates room to fix up the zero-value trace point in the API. Signed-off-by: Glib Smaga <code@gsmaga.com>
Signed-off-by: Glib Smaga <code@gsmaga.com>
|
Please set the appropriate release note label. |
michi-covalent
approved these changes
Jun 15, 2020
Contributor
michi-covalent
left a comment
There was a problem hiding this comment.
this makes sense to me as well.
gandro
approved these changes
Jun 16, 2020
Member
|
test-me-please |
rolinh
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different approach from #11934 which is obsoleted by this PR.
To me this PR makes more sense and actually untangles the zero value problem which we need to fix one way or another.