api/v1: Include string representations of data path types#11934
api/v1: Include string representations of data path types#11934
Conversation
Signed-off-by: Glib Smaga <code@gsmaga.com>
In addition to integer typing, decode into string names to make it more human readable. This is going to be incorporated in both, the upcoming CI tests for segment tracking of trace notifications an in the hubble-cli display. Signed-off-by: Glib Smaga <code@gsmaga.com>
|
Please set the appropriate release note label. |
|
i'm a bit torn about this, whether the field should be a string or an enum. i understand that maintaining an enum might become too much work, but i think it would make the api easier to use. what do you all think? |
That's a good point, enum is probably better here since it's a finite set |
|
Marked for backport (and consequently removed the |
|
test-me-please |
|
@glibsm Are you planning to change this PR to use enums? If so, please change the PR status to draft. If no action is taken, the current version will likely get merged eventually (as it will eventually pass CI and has the Hubble subteam approval). This would be fine by me, but your last comment suggests you wanted to reiterate on the approach. |
|
@gandro the train to declare this DRAFT has long gone since you can only open the PR as draft :) I can tag this as do-not-merge until the decision is made. |
You can now! https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft/ |
|
How could I have possibly missed it? |
|
Superseeded by #12085 |
Fixes cilium/hubble#277