1.8 documentation updates: Concepts & menu structure#11979
Merged
Conversation
c809196 to
9f1823c
Compare
joestringer
requested changes
Jun 9, 2020
Member
joestringer
left a comment
There was a problem hiding this comment.
Some minor comments as a first pass.
christarazi
reviewed
Jun 9, 2020
Member
christarazi
left a comment
There was a problem hiding this comment.
First-pass comments, looks good overall
04011b5 to
0bcd132
Compare
da20b5d to
34c7d5f
Compare
Contributor
Author
|
I will wait with the rebase until final reviews come in |
Contributor
michi-covalent
left a comment
There was a problem hiding this comment.
reviewed:
- Documentation/intro.rst
- Documentation/index.rst
- Documentation/concepts/overview.rst
qmonnet
reviewed
Jun 15, 2020
Contributor
Author
|
FYI: The vast majority of comments are on existing documentation that was moved. I don't mind addressing all of it but it may make future reviews harder. |
* Move the detailed flow deep dive into a sub section * Mark Cluster Scope / Pool as the default IPAM * Mark old host scope as legacy Signed-off-by: Thomas Graf <thomas@cilium.io>
* Mention all involved components * Use the compoonent overview for a high-level description. More detailed descriptions will be added in dedicated concepts chapters. Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
The different routing modes have been spread across multiple different chapters. Consolidate it all in a single place: Concepts -> Networking -> Routing. Also split out multi-cluster to extend it later. Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
Also removes the oudated Kubernetes section. Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
It only refers to the getting started guide Signed-off-by: Thomas Graf <thomas@cilium.io>
The information is duplicated from the getting started guide. Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
Also removes an outdated section about future roadmap Signed-off-by: Thomas Graf <thomas@cilium.io>
tklauser
added a commit
that referenced
this pull request
Jun 18, 2020
The documentation about the BPF map scale and limitation is currently duplicated. The version in the "Introduction" section (intro.rst) was updated with the most recent changes, while the version in the "Maps" section (which was split out in #11979 into maps.rst) contains an outdated version. Move all the up-to-date info to maps.rst. Incidentally, this also makes the last sentence in the previous section "Below we show the following possible flows..." make sense again since it refers to the figure in section "Kubernetes Integration". Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
joestringer
pushed a commit
that referenced
this pull request
Jun 18, 2020
The documentation about the BPF map scale and limitation is currently duplicated. The version in the "Introduction" section (intro.rst) was updated with the most recent changes, while the version in the "Maps" section (which was split out in #11979 into maps.rst) contains an outdated version. Move all the up-to-date info to maps.rst. Incidentally, this also makes the last sentence in the previous section "Below we show the following possible flows..." make sense again since it refers to the figure in section "Kubernetes Integration". Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
borkmann
pushed a commit
that referenced
this pull request
Jun 18, 2020
[ upstream commit 3ab3d68 ] The documentation about the BPF map scale and limitation is currently duplicated. The version in the "Introduction" section (intro.rst) was updated with the most recent changes, while the version in the "Maps" section (which was split out in #11979 into maps.rst) contains an outdated version. Move all the up-to-date info to maps.rst. Incidentally, this also makes the last sentence in the previous section "Below we show the following possible flows..." make sense again since it refers to the figure in section "Kubernetes Integration". Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
borkmann
pushed a commit
that referenced
this pull request
Jun 18, 2020
[ upstream commit 3ab3d68 ] The documentation about the BPF map scale and limitation is currently duplicated. The version in the "Introduction" section (intro.rst) was updated with the most recent changes, while the version in the "Maps" section (which was split out in #11979 into maps.rst) contains an outdated version. Move all the up-to-date info to maps.rst. Incidentally, this also makes the last sentence in the previous section "Below we show the following possible flows..." make sense again since it refers to the figure in section "Kubernetes Integration". Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.