Skip to content

test: add retries to expected successful curl calls#11797

Merged
borkmann merged 1 commit intomasterfrom
pr/retry-curl-proxy-redirect
Jun 3, 2020
Merged

test: add retries to expected successful curl calls#11797
borkmann merged 1 commit intomasterfrom
pr/retry-curl-proxy-redirect

Conversation

@nebril
Copy link
Copy Markdown
Member

@nebril nebril commented Jun 1, 2020

No description provided.

@nebril nebril requested a review from a team as a code owner June 1, 2020 11:23
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 1, 2020

Please set the appropriate release note label.

@nebril nebril added the release-note/ci This PR makes changes to the CI. label Jun 1, 2020
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 1, 2020

test-4.9

@nebril nebril force-pushed the pr/retry-curl-proxy-redirect branch from 0890e3e to 70f4a01 Compare June 1, 2020 11:27
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 1, 2020

test-4.9

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 1, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 36.904% when pulling 51337ce on pr/retry-curl-proxy-redirect into 82fafa7 on master.

@nebril nebril force-pushed the pr/retry-curl-proxy-redirect branch from 70f4a01 to 128a6e1 Compare June 1, 2020 13:09
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 1, 2020

test-4.9

tgraf
tgraf suggested changes Jun 2, 2020
View reviewed changes
Comment thread test/k8sT/Policies.go Outdated
@nebril
test: add retries to expected successful curl calls
51337ce 
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/retry-curl-proxy-redirect branch from 128a6e1 to 51337ce Compare June 2, 2020 16:50
@nebril nebril requested a review from tgraf June 2, 2020 16:50
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 2, 2020

test-focus K8sPolicyTest

@nebril nebril added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 3, 2020
@borkmann borkmann merged commit 59df34f into master Jun 3, 2020
@borkmann borkmann deleted the pr/retry-curl-proxy-redirect branch June 3, 2020 20:18
@tklauser tklauser mentioned this pull request Jun 4, 2020
Merged
christarazi added a commit to christarazi/cilium that referenced this pull request Jun 9, 2020
@christarazi
test: Add retries to curl command
036087e 
The curl is reaching out to a world / external resource so retrying is
acceptable, and helps test flakes.

Fixes: cilium#11797

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi mentioned this pull request Jun 9, 2020
Closed
nebril pushed a commit that referenced this pull request Jun 10, 2020
@christarazi @nebril
test: Add retries to curl command
47f8d32 
The curl is reaching out to a world / external resource so retrying is
acceptable, and helps test flakes.

Fixes: #11797

Signed-off-by: Chris Tarazi <chris@isovalent.com>
aanm pushed a commit that referenced this pull request Jun 11, 2020
@christarazi @aanm
test: Add retries to curl command
28fa17a 
[ upstream commit 47f8d32 ]

The curl is reaching out to a world / external resource so retrying is
acceptable, and helps test flakes.

Fixes: #11797

Signed-off-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: André Martins <andre@cilium.io>
joestringer pushed a commit that referenced this pull request Jun 12, 2020
@christarazi @joestringer
test: Add retries to curl command
0b8f920 
[ upstream commit 47f8d32 ]

The curl is reaching out to a world / external resource so retrying is
acceptable, and helps test flakes.

Fixes: #11797

Signed-off-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: André Martins <andre@cilium.io>
jrajahalme pushed a commit that referenced this pull request Jul 1, 2020
@christarazi @jrajahalme
test: Add retries to curl command
51a5047 
[ upstream commit 47f8d32 ]

The curl is reaching out to a world / external resource so retrying is
acceptable, and helps test flakes.

Fixes: #11797

Signed-off-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme pushed a commit that referenced this pull request Jul 1, 2020
@christarazi @jrajahalme
test: Add retries to curl command
5e6ff09 
[ upstream commit 47f8d32 ]

The curl is reaching out to a world / external resource so retrying is
acceptable, and helps test flakes.

Fixes: #11797

Signed-off-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
aanm pushed a commit that referenced this pull request Jul 1, 2020
@christarazi @aanm
test: Add retries to curl command
b0025ed 
[ upstream commit 47f8d32 ]

The curl is reaching out to a world / external resource so retrying is
acceptable, and helps test flakes.

Fixes: #11797

Signed-off-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
joestringer pushed a commit that referenced this pull request Jul 1, 2020
@christarazi @joestringer
test: Add retries to curl command
2127c82 
[ upstream commit 47f8d32 ]

The curl is reaching out to a world / external resource so retrying is
acceptable, and helps test flakes.

Fixes: #11797

Signed-off-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qmonnet qmonnet qmonnet approved these changes

+1 more reviewer

@tgraf tgraf tgraf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nebril @coveralls @tgraf @qmonnet @tklauser @borkmann @b3a-dev