Update CODEOWNERS and hide go.sum#11125
Merged
joestringer merged 5 commits intomasterfrom May 4, 2020
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
c9ece8f to
b87d999
Compare
christarazi
approved these changes
Apr 23, 2020
Member
christarazi
left a comment
There was a problem hiding this comment.
Nice! Thanks for keeping this up-to-date.
aanm
requested changes
Apr 23, 2020
Member
aanm
left a comment
There was a problem hiding this comment.
I assume you will be adding the / on all lines?
b87d999 to
e2eac74
Compare
Member
Author
|
@aanm Done. There are a few entries that remain without a |
e2eac74 to
e62c605
Compare
aanm
reviewed
Apr 24, 2020
joestringer
requested changes
Apr 24, 2020
Member
joestringer
left a comment
There was a problem hiding this comment.
Nice improvements. I figured this is a good opportunity to review the list as well so I added some comments that may be not directly related to the changes you're suggesting, but worth looking at while we're tweaking the file.
joestringer
reviewed
Apr 24, 2020
joestringer
reviewed
Apr 24, 2020
aanm
requested changes
Apr 27, 2020
e62c605 to
1295620
Compare
1295620 to
424ba40
Compare
tklauser
reviewed
Apr 30, 2020
39a6863 to
e2858f3
Compare
Member
Author
|
@aanm @cilium/ipam seems to be missing. |
Member
Member
Author
|
@aanm The text at the top was there for that. If all team names become bold, it means the PR can be merged (once reviews are in) :-) |
joestringer
requested changes
May 1, 2020
Member
joestringer
left a comment
There was a problem hiding this comment.
Couple of remaining nits, in particular the IMAP bit 😄
qmonnet
approved these changes
May 1, 2020
This commit reworks the code owner entries, mostly to avoid matching the
catch-all janitors team unless it makes sense. In particular, it
- fixes a few entries in api/, pkg/option/, pkg/service/, and
install/kubernetes/.
- introduces a new team cilium/build;
- moves development tools under cilium/contributing;
- removes specific code owners to prefer teams;
- adds go.{sum,mod} to cilium/vendor.
Signed-off-by: Paul Chaignon <paul@cilium.io>
Mark go.sum files as generated to hide them in pull requests by default. They can still be uncollapsed if needed. This particular .gitattributes syntax is documented at [1]. GitHub doesn't hide them by default because some users may want to inspect these files (see [2] upstream for details). 1 - https://github.com/github/linguist/#using-gitattributes 2 - github-linguist/linguist#4660 Signed-off-by: Paul Chaignon <paul@cilium.io>
e2858f3 to
b4a83c6
Compare
joestringer
requested changes
May 4, 2020
Member
joestringer
left a comment
There was a problem hiding this comment.
One last nit, almost there :)
This commit attaches most entries to the root of the repository to ensure we don't match folders and files in subdirectories. Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
b4a83c6 to
164c5fb
Compare
joestringer
approved these changes
May 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit reworks the code owner entries, mostly to avoid matching the catch-all janitors group unless it makes sense. In particular, it:
@cilium/contributing;go.{sum,mod}to@cilium/vendor.As is, this pull request requires the creation of four new groups in the Cilium organization: @cilium/ipam, @cilium/build, @cilium/aws, and @cilium/azure.
This leaves two fairly commonly touched packages (
pkg/nodeandpkg/aws) under@cilium/janitors, but I'm not sure there's a good group to assign them.The second commit hides
go.sumfiles by default in pull requests since these are generated. We will still be able to uncollapse them if needed.