cilium: various xdp related follow-ups by borkmann · Pull Request #10910 · cilium/cilium

borkmann · 2020-04-09T10:51:47Z

cilium status output
CI tests
Hide generic XDP for testing only

Remap the XDP generic option from "generic" into "testing-only". The reason is that we don't want to encourage users to run with generic XDP at this point but only with the fast native one instead. Generic XDP has several downside: - Still operates on skbs - Linearizes & unclones every skb - Bypasses GRO These are severe limitations which the native XDP mode does not have and could potentially make its operation slower than the tc ingress one. The generic XDP is however very useful for testing purpose and we would like to use it in our CI. Therefore, change it into an undocumented "testing-only" option value that we can use internally. For the --prefilter-mode, the ship has sailed on "generic" therefore we keep it intact and remap into "testing-only" internally. Simplify the documentation as well and remove the prior warning that generic XDP should not be used in a production environment. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

Dump the XDP acceleration mode in the cilium status output in order to see if BPF was attached and in which XDP mode. The hidden generic option value is dumped as "GENERIC" here since in XDP context it's called generic XDP. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

maintainer-s-little-helper · 2020-04-09T10:51:50Z

Please set the appropriate release note label.

maintainer-s-little-helper · 2020-04-09T10:51:50Z

Please set the appropriate release note label.

maintainer-s-little-helper · 2020-04-09T10:51:50Z

Please set the appropriate release note label.

maintainer-s-little-helper · 2020-04-09T10:51:50Z

Please set the appropriate release note label.

borkmann · 2020-04-09T10:52:08Z

test-me-please

borkmann · 2020-04-09T11:16:41Z

test-me-please

borkmann · 2020-04-09T11:56:44Z

unrelated vagrant issue:

 97 9861M   97 9609M    0     0   100M      0  0:01:38  0:01:35  0:00:03  112M
 98 9861M   98 9721M    0     0   100M      0  0:01:37  0:01:36  0:00:01  112M
 99 9861M   99 9833M    0     0   100M      0  0:01:37  0:01:37 --:--:--  112M
100 9861M  100 9861M    0     0   100M      0  0:01:37  0:01:37 --:--:--  112M
11:27:23  The machine index which stores all required information about
11:27:23  running Vagrant environments has become corrupt. This is usually
11:27:23  caused by external tampering of the Vagrant data folder.
11:27:23  
11:27:23  Vagrant cannot manage any Vagrant environments if the index is
11:27:23  corrupt. Please attempt to manually correct it. If you are unable
11:27:23  to manually correct it, then remove the data file at the path below.
11:27:23  This will leave all existing Vagrant environments "orphaned" and
11:27:23  they'll have to be destroyed manually.
11:27:23  
11:27:23  Path: /root/.vagrant.d/data/machine-index/index
11:27:24  box locked or unavailable, adding box from vagrant cloud
11:27:25  The machine index which stores all required information about
11:27:25  running Vagrant environments has become corrupt. This is usually
11:27:25  caused by external tampering of the Vagrant data folder.
11:27:25  
11:27:25  Vagrant cannot manage any Vagrant environments if the index is
11:27:25  corrupt. Please attempt to manually correct it. If you are unable
11:27:25  to manually correct it, then remove the data file at the path below.
11:27:25  This will leave all existing Vagrant environments "orphaned" and
11:27:25  they'll have to be destroyed manually.
11:27:25  
11:27:25  Path: /root/.vagrant.d/data/machine-index/index
Post stage

coveralls · 2020-04-09T12:06:45Z

Coverage increased (+0.0004%) to 46.636% when pulling 44cd7e9 on pr/xdp-follow-ups into 30e8837 on master.

borkmann · 2020-04-09T12:27:34Z

test-me-please

borkmann · 2020-04-09T13:09:35Z

provisioning issue again:

[Pipeline] sh
12:37:23  + /usr/local/bin/add_vagrant_box /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/vagrant_box_defaults.rb
12:37:23  The machine index which stores all required information about
12:37:23  running Vagrant environments has become corrupt. This is usually
12:37:23  caused by external tampering of the Vagrant data folder.
12:37:23  [...]

borkmann · 2020-04-09T13:09:44Z

test-me-please

borkmann · 2020-04-09T15:14:12Z

Hit flake #10821

borkmann · 2020-04-09T15:15:05Z

test-focus K8sService.*

borkmann · 2020-04-09T15:15:20Z

test-me-please

borkmann · 2020-04-09T17:53:45Z

test-focus K8sService.*

borkmann · 2020-04-09T20:02:13Z

test-me-please

borkmann · 2020-04-09T20:04:12Z

Hit flake #10821

borkmann · 2020-04-09T20:04:22Z

test-focus K8sService.*

borkmann · 2020-04-09T20:46:18Z

Cilium-Tests-With-Kernel provision issue

20:45:04  Checking for older boxes...
20:45:04  No old versions of boxes to remove...
20:45:04  VBoxManage: error: Machine '9c85c1b7-53ab-4012-837a-749c5acf0af8' is not currently running
20:45:04  0%...10%...20%...30%...40%...
20:45:04  Progress state: VBOX_E_OBJECT_IN_USE
20:45:04  VBoxManage: error: Machine delete failed
20:45:04  VBoxManage: error: Cannot close medium '/root/VirtualBox VMs/ubuntu-18.04.4-amd64-11_1586464889876_63179/ubuntu-18.04.4-amd64-11-disk001.vmdk' because it has 1 child media
20:45:04  VBoxManage: error: Details: code VBOX_E_OBJECT_IN_USE (0x80bb000c), component MediumWrap, interface IMedium
20:45:04  VBoxManage: error: Context: "RTEXITCODE handleUnregisterVM(HandlerArg*)" at line 162 of file VBoxManageMisc.cpp
20:45:04  VBoxManage: error: Machine 'ab8f39a8-4e2d-4dc1-bb3e-da306b749f17' is not currently running
20:45:06  0%...10%...20%...30%...40%...50%...60%...70%...80%...90%...100%
20:45:06  Clean docker images from registry

borkmann · 2020-04-09T20:46:29Z

test-with-kernel

borkmann · 2020-04-09T21:01:58Z

test-focus K8sService.*

borkmann · 2020-04-09T22:12:36Z

vagrant issue again in CI...

borkmann · 2020-04-09T22:12:39Z

test-focus K8sService.*

borkmann · 2020-04-09T23:36:24Z

test-focus K8sService.*

borkmann · 2020-04-09T23:36:31Z

test-me-please

borkmann · 2020-04-10T00:34:27Z

vbox error in CI:

00:31:39  Stderr: VBoxManage: error: Failed to create the VirtualBox object!
00:31:39  VBoxManage: error: Document is empty.
00:31:39  VBoxManage: error: Location: '/root/.config/VirtualBox/VirtualBox.xml', line 1 (0), column 1.
00:31:39  VBoxManage: error: /home/vbox/vbox-6.0.18/src/VBox/Main/src-server/VirtualBoxImpl.cpp[624] (nsresult VirtualBox::init())
00:31:39  VBoxManage: error: Details: code NS_ERROR_FAILURE (0x80004005), component VirtualBoxWrap, interface IVirtualBox
00:31:39  script returned exit code 143

borkmann · 2020-04-10T00:34:35Z

test-me-please

joestringer · 2020-04-10T03:44:17Z

Hit #10929 and #10930, will restart ginkgo.

joestringer · 2020-04-10T03:44:23Z

restart-ginkgo

Avoid having to leave around stale XDP programs when the config changes. Therefore do the same as we do in tc which is to clean up prior state. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

Add tests for generic XDP under DSR/SNAT/Hybrid modes to our CI and also test base functionality to make sure all the rest is working as expected when XDP is attached. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

Add also tests for (external) TC under DSR/SNAT/Hybrid modes to our CI so they can be performed from the third host. So far we don't seem to test all of them (only for the metal LB case). Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

borkmann · 2020-04-10T12:57:56Z

test-me-please

borkmann · 2020-04-10T12:58:05Z

test-focus K8sService.*

christarazi · 2020-10-16T06:58:19Z

Backported only 7d1a16f to v1.7 (PR: #13595) as #13532 depended on this commit.

borkmann added 2 commits April 9, 2020 10:42

borkmann added pending-review area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels Apr 9, 2020

borkmann requested review from a team and brb April 9, 2020 10:51

borkmann requested review from a team as code owners April 9, 2020 10:51

maintainer-s-little-helper Bot added dont-merge/needs-release-note labels Apr 9, 2020

borkmann added the release-note/misc This PR makes changes that have no direct user impact. label Apr 9, 2020

maintainer-s-little-helper Bot removed the dont-merge/needs-release-note label Apr 9, 2020

borkmann force-pushed the pr/xdp-follow-ups branch from ab3ec9a to ee37c1e Compare April 9, 2020 11:16

brb approved these changes Apr 9, 2020

View reviewed changes

borkmann force-pushed the pr/xdp-follow-ups branch from 1b16636 to e9e8711 Compare April 9, 2020 21:01

borkmann force-pushed the pr/xdp-follow-ups branch from e9e8711 to ffe1389 Compare April 9, 2020 23:35

This was referenced Apr 10, 2020

CI: K8sServicesTest Checks service across nodes Supports IPv4 Fragments: Failed to account for IPv4 fragments #10929

Closed

CI: K8sUpdates Tests upgrade and downgrade from a Cilium stable image to master: Node Lost #10930

Closed

borkmann added 3 commits April 10, 2020 11:01

bpf: clean up XDP from prior devices when cilium configuration changes

7d1a16f

Avoid having to leave around stale XDP programs when the config changes. Therefore do the same as we do in tc which is to clean up prior state. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

testing: enable generic XDP tests for NodePort in CI

79aaac6

Add tests for generic XDP under DSR/SNAT/Hybrid modes to our CI and also test base functionality to make sure all the rest is working as expected when XDP is attached. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

borkmann force-pushed the pr/xdp-follow-ups branch from ffe1389 to 44cd7e9 Compare April 10, 2020 12:57

borkmann requested a review from a team April 10, 2020 12:57

borkmann merged commit 0626fcd into master Apr 10, 2020

borkmann deleted the pr/xdp-follow-ups branch April 10, 2020 15:19

christarazi mentioned this pull request Oct 16, 2020

v1.7 backports 2020-10-15 #13595

Merged

Conversation

borkmann commented Apr 9, 2020

Uh oh!

maintainer-s-little-helper Bot commented Apr 9, 2020

Uh oh!

maintainer-s-little-helper Bot commented Apr 9, 2020

Uh oh!

maintainer-s-little-helper Bot commented Apr 9, 2020

Uh oh!

maintainer-s-little-helper Bot commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

coveralls commented Apr 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 9, 2020

Uh oh!

borkmann commented Apr 10, 2020

Uh oh!

borkmann commented Apr 10, 2020

Uh oh!

joestringer commented Apr 10, 2020

Uh oh!

joestringer commented Apr 10, 2020

Uh oh!

borkmann commented Apr 10, 2020

Uh oh!

borkmann commented Apr 10, 2020

Uh oh!

christarazi commented Oct 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coveralls commented Apr 9, 2020 •

edited

Loading