bpf: only clean up XDP from devices with XDP attached#13532
Merged
tklauser merged 1 commit intocilium:masterfrom Oct 14, 2020
Merged
bpf: only clean up XDP from devices with XDP attached#13532tklauser merged 1 commit intocilium:masterfrom
tklauser merged 1 commit intocilium:masterfrom
Conversation
Currently, during agent startup, cilium removes XDP from all interfaces except for `cilium_host`, `cilium_net` and `$XDP_DEV` regardless of whether there is an XDP program attached to it. For some drivers, e.g. Mellanox mlx5, the following command will cause device reset regardless of whether there is an XDP program attached to it, which introduces node and pod network interruption: `ip link set dev $DEV xdpdrv off`. This patch adds a check of XDP program existence to avoid such network interruption. Fixes: cilium#13526 Reported-by: ArthurChiao <arthurchiao@hotmail.com> Signed-off-by: Jaff Cheng <jaff.cheng.sh@gmail.com>
Member
|
test-me-please |
pchaigno
reviewed
Oct 13, 2020
pchaigno
approved these changes
Oct 13, 2020
vadorovsky
approved these changes
Oct 14, 2020
tklauser
approved these changes
Oct 14, 2020
This was referenced Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, during agent startup, cilium removes XDP from all
interfaces except for
cilium_host,cilium_netand$XDP_DEVregardless of whether there is an XDP program attached to it.
For some drivers, e.g. Mellanox mlx5, the following command will
cause device reset regardless of whether there is an XDP program
attached to it, which introduces node and pod network interruption:
ip link set dev $DEV xdpdrv off.This patch adds a check of XDP program existence to avoid such
network interruption.
Fixes: #13526
Reported-by: ArthurChiao arthurchiao@hotmail.com
Signed-off-by: Jaff Cheng jaff.cheng.sh@gmail.com