Add from_timestamp_micros function by umanwizard · Pull Request #906 · chronotope/chrono

umanwizard · 2022-12-13T19:22:01Z

Fixes #904

djc

LGTM, thanks!

djc · 2022-12-14T10:32:24Z

src/naive/datetime/tests.rs

+        (2034061609000000, "2034-06-16 09:06:49.000000000"),
+    ];
+
+    for (timestamp_micros, formatted) in valid_map.iter().cloned() {


Nit: cloned() -> copied().

djc · 2022-12-14T10:32:32Z

src/naive/datetime/tests.rs

+
+    let invalid = [i64::MAX, i64::MIN];
+
+    for timestamp_micros in invalid.iter().cloned() {


djc · 2022-12-14T10:32:38Z

src/naive/datetime/tests.rs

+    // Test that the result of `from_timestamp_micros` compares equal to
+    // that of `from_timestamp_opt`.
+    let secs_test = [0, 1, 2, 1000, 1234, 12345678, -1, -2, -1000, -12345678];
+    for secs in secs_test.iter().cloned() {


djc · 2022-12-14T10:32:42Z

src/naive/datetime/mod.rs

        datetime.expect("invalid or out-of-range datetime")
    }

+    /// Creates a new [NaiveDateTime] from milliseconds or microseconds since the UNIX epoch.


Style nit: I would prefer this (private) API to be ordered below the public users of this method.

umanwizard · 2022-12-14T14:17:16Z

I have changed cloned to copied in the test (and in the similar test for from_timestamp_millis), and moved the private method to the very bottom of the impl block.

esheppa

Looks great!

esheppa · 2022-12-15T02:20:26Z

src/naive/datetime/tests.rs

+
+    // Test that the result of `from_timestamp_micros` compares equal to
+    // that of `from_timestamp_opt`.
+    let secs_test = [0, 1, 2, 1000, 1234, 12345678, -1, -2, -1000, -12345678];


Thanks for adding this here as well!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [chrono](https://github.com/chronotope/chrono) | dependencies | patch | `0.4.23` -> `0.4.24` | --- ### Release Notes <details> <summary>chronotope/chrono</summary> ### [`v0.4.24`](https://github.com/chronotope/chrono/releases/tag/v0.4.24): 0.4.24 [Compare Source](chronotope/chrono@v0.4.23...v0.4.24) This is a small maintenance release with accumulated fixes and improvements. - Fix doc on `Days::new()` to refer to days, not months ([#874](chronotope/chrono#874), thanks to [@brotskydotcom](https://github.com/brotskydotcom)) - Clarify out of range value for `from_timestamp_opt()` ([#879](chronotope/chrono#879), thanks to [@xmo-odoo](https://github.com/xmo-odoo)) - Add `format_localized()` for `NaiveDate` ([#881](chronotope/chrono#881), thanks to [@mseele](https://github.com/mseele)) - Fix bug in `Add`/`Sub` `Days`, add tests with DST timezone ([#878](chronotope/chrono#878)) - Make `NaiveTime::MIN` public ([#890](chronotope/chrono#890)) - Fix `from_timestamp_millis()` implementation and add more tests ([#885](chronotope/chrono#885)) - Fix typo in docstrings ([#897](chronotope/chrono#897), thanks to [@dandxy89](https://github.com/dandxy89)) - Add test proving that [#903](chronotope/chrono#903) is fixed in 0.4.x head ([#905](chronotope/chrono#905), thanks to [@umanwizard](https://github.com/umanwizard)) - Add `from_timestamp_micros()` function ([#906](chronotope/chrono#906), thanks to [@umanwizard](https://github.com/umanwizard)) - Check cargo-deny in CI ([#909](chronotope/chrono#909)) - Derive `Hash` for most pub types that also derive `PartialEq` ([#938](chronotope/chrono#938), thanks to [@bruceg](https://github.com/bruceg)) - Update deprecated methods in `from_utc()` example ([#939](chronotope/chrono#939), thanks to [@greg-el](https://github.com/greg-el)) - Fix panic in `DateTime::checked_add_days()` ([#942](chronotope/chrono#942), thanks to [@Ekleog](https://github.com/Ekleog)) - More documentation for dates before 1 BCE or after 9999 CE ([#950](chronotope/chrono#950), thanks to [@cgit](https://github.com/cgit)) - Improve `FixedOffset` docs ([#953](chronotope/chrono#953), thanks to [@klnusbaum](https://github.com/klnusbaum)) - Add chrono-fuzz to CI and update its libfuzzer-sys dependency ([#968](chronotope/chrono#968), thanks to [@LingMan](https://github.com/LingMan)) - Fixes to parsing and calculation of week numbers ([#966](chronotope/chrono#966), thanks to [@raphaelroosz](https://github.com/raphaelroosz)) - Make iana-time-zone a target specific dependency ([#980](chronotope/chrono#980), thanks to [@krtab](https://github.com/krtab)) - Make eligible functions `const` ([#984](chronotope/chrono#984), thanks to [@tormeh](https://github.com/tormeh)) Thanks to all contributors from the chrono team, [@esheppa](https://github.com/esheppa) and [@djc](https://github.com/djc). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1815 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

umanwizard mentioned this pull request Dec 13, 2022

Add from_timestamp_micros function MaterializeInc/chrono#1

Closed

djc approved these changes Dec 14, 2022

View reviewed changes

djc requested a review from esheppa December 14, 2022 10:32

Add from_timestamp_micros function

785096b

umanwizard force-pushed the from_timestamp_micros branch from 6745898 to 785096b Compare December 14, 2022 14:16

esheppa approved these changes Dec 15, 2022

View reviewed changes

djc merged commit a1591e9 into chronotope:0.4.x Dec 15, 2022

umanwizard mentioned this pull request Dec 16, 2022

Switch to HEAD of Chrono 0.4.x MaterializeInc/materialize#16702

Merged

3 tasks

umanwizard mentioned this pull request Dec 27, 2022

Feature request: NaiveDateTime::from_timestamp_micros #904

Closed

djc mentioned this pull request Jan 3, 2023

0.4.24 release planning #929

Closed

pitdicker mentioned this pull request May 15, 2023

Add from_timestamp_nanos|micros|millis functions for NaiveDateTime #562

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add from_timestamp_micros function#906

Add from_timestamp_micros function#906
djc merged 1 commit intochronotope:0.4.xfrom
MaterializeInc:from_timestamp_micros

umanwizard commented Dec 13, 2022

Uh oh!

djc left a comment

Uh oh!

djc Dec 14, 2022

Uh oh!

djc Dec 14, 2022

Uh oh!

djc Dec 14, 2022

Uh oh!

djc Dec 14, 2022

Uh oh!

umanwizard commented Dec 14, 2022 •

edited

Loading

Uh oh!

esheppa left a comment

Uh oh!

esheppa Dec 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		let invalid = [i64::MAX, i64::MIN];

		for timestamp_micros in invalid.iter().cloned() {

Conversation

umanwizard commented Dec 13, 2022

Uh oh!

djc left a comment

Choose a reason for hiding this comment

Uh oh!

djc Dec 14, 2022

Choose a reason for hiding this comment

Uh oh!

djc Dec 14, 2022

Choose a reason for hiding this comment

Uh oh!

djc Dec 14, 2022

Choose a reason for hiding this comment

Uh oh!

djc Dec 14, 2022

Choose a reason for hiding this comment

Uh oh!

umanwizard commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

esheppa left a comment

Choose a reason for hiding this comment

Uh oh!

esheppa Dec 15, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

umanwizard commented Dec 14, 2022 •

edited

Loading