Don't record the current date in header file comments if the SOURCE_DATE_EPOCH environment variable is set#4152
Merged
magreenblatt merged 1 commit intoApr 15, 2026
Conversation
…DATE_EPOCH` environment variable is set Recording the current date in header file comments (from the `cef_api_untracked.json` file generated during the build) introduces non-deterministic timestamps into build artifacts, preventing [reproducible builds](https://reproducible-builds.org/) (see the [diffoscope output](https://reproducible.archlinux.org/api/v0/builds/1028387/diffoscope)). This commit skips generating date based comments for untracked versions if the [SOURCE_DATE_EPOCH environment variable](https://reproducible-builds.org/docs/source-date-epoch/) is set, allowing reproducible builds in environments that expect them.
Collaborator
|
Thanks, looks good. |
magreenblatt
pushed a commit
that referenced
this pull request
Apr 16, 2026
) Recording the current date in header file comments (from the `cef_api_untracked.json` file generated during the build) introduces non-deterministic timestamps into build artifacts, preventing [reproducible builds](https://reproducible-builds.org/) (see the [diffoscope output](https://reproducible.archlinux.org/api/v0/builds/1028387/diffoscope)). This commit skips generating date based comments for untracked versions if the [SOURCE_DATE_EPOCH environment variable](https://reproducible-builds.org/docs/source-date-epoch/) is set, allowing reproducible builds in environments that expect them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording the current date in header file comments (from the
cef_api_untracked.jsonfile generated during the build) introduces non-deterministic timestamps into build artifacts, preventing reproducible builds (see the diffoscope output).This commit skips generating date based comments for untracked versions if the SOURCE_DATE_EPOCH environment variable is set, allowing reproducible builds in environments that expect them.