Skip to content

Update GraphQL schema and handle ComparisonResult.SKIPPED value#379

Merged
ghengeveld merged 2 commits intonextfrom
update-graphql-schema
Jun 11, 2025
Merged

Update GraphQL schema and handle ComparisonResult.SKIPPED value#379
ghengeveld merged 2 commits intonextfrom
update-graphql-schema

Conversation

@ghengeveld
Copy link
Copy Markdown
Member

@ghengeveld ghengeveld commented Jun 10, 2025

Fixes #365

The Chromatic API can now return SKIPPED for certain comparisons. This updates VTA to handle those situations.

📦 Published PR as canary version: 4.0.1--canary.379.41a22f0.0

✨ Test out this PR locally via:

npm install @chromatic-com/storybook@4.0.1--canary.379.41a22f0.0
# or 
yarn add @chromatic-com/storybook@4.0.1--canary.379.41a22f0.0

Version

Published prerelease version: v4.1.0-next.1

Changelog

🚀 Enhancement

🐛 Bug Fix

  • Update GraphQL schema and handle ComparisonResult.SKIPPED value #379 (@ghengeveld)

Authors: 1

@ghengeveld ghengeveld added bug Classification: Something isn't working release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Jun 10, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 10, 2025

Codecov Report

❌ Patch coverage is 15.21739% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.04%. Comparing base (c0ca974) to head (41a22f0).
⚠️ Report is 20 commits behind head on next.

Files with missing lines Patch % Lines
src/components/BrowserSelector.stories.ts 0.00% 11 Missing ⚠️
src/components/ModeSelector.stories.ts 0.00% 11 Missing ⚠️
src/components/BrowserSelector.tsx 0.00% 8 Missing ⚠️
src/components/ModeSelector.tsx 0.00% 8 Missing ⚠️
src/components/StatusDot.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            next    #379      +/-   ##
========================================
+ Coverage   6.02%   6.04%   +0.01%     
========================================
  Files        169     169              
  Lines      14229   14269      +40     
  Branches     302     301       -1     
========================================
+ Hits         857     862       +5     
- Misses     13290   13325      +35     
  Partials      82      82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghengeveld ghengeveld merged commit 9978d3e into next Jun 11, 2025
9 checks passed
@ghengeveld ghengeveld deleted the update-graphql-schema branch June 11, 2025 07:31
@ghengeveld ghengeveld mentioned this pull request Jun 20, 2025
This was referenced Aug 1, 2025
@ghengeveld
Copy link
Copy Markdown
Member Author

🚀 PR was released in v4.1.0 🚀

@ghengeveld ghengeveld added released Verdict: This issue/pull request has been released and removed prerelease labels Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Classification: Something isn't working patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect error message

2 participants