deepcopy: gen: match Go 1.17 build tag format#1
Merged
christarazi merged 1 commit intochristarazi:masterfrom Sep 7, 2021
tklauser:pr/tklauser/add-go-build-tags
Merged
deepcopy: gen: match Go 1.17 build tag format#1christarazi merged 1 commit intochristarazi:masterfrom tklauser:pr/tklauser/add-go-build-tags
christarazi merged 1 commit intochristarazi:masterfrom
tklauser:pr/tklauser/add-go-build-tags
Conversation
The Go team has started the process of replacing the old "// +build" constraints with the new "//go:build" constraints. See the design doc for more details here: https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md What is relevant is that in Go 1.17, gofmt now synchronizes the two styles. In particular, if gofmt is run against a deepcopy generated file, it will add a new "//go:build" constraint. See https://golang.org/doc/go1.17#gofmt for details. This PR intends to make it so that the generated code is compliant with the new gofmt style. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
christarazi
approved these changes
Sep 7, 2021
christarazi
added a commit
to christarazi/cilium
that referenced
this pull request
Dec 8, 2021
Move the fork of controller-tools from my personal fork to be officially part of the Cilium repo. Along the way, add the commit from christarazi/controller-tools#1 to the v0.6.2 branch. Signed-off-by: Chris Tarazi <chris@isovalent.com>
tklauser
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 16, 2021
Move the fork of controller-tools from my personal fork to be officially part of the Cilium repo. Along the way, add the commit from christarazi/controller-tools#1 to the v0.6.2 branch. Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added a commit
to christarazi/cilium
that referenced
this pull request
Jan 3, 2022
[ upstream commit ddb5482 ] Move the fork of controller-tools from my personal fork to be officially part of the Cilium repo. Along the way, add the commit from christarazi/controller-tools#1 to the v0.6.2 branch. Signed-off-by: Chris Tarazi <chris@isovalent.com> Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added a commit
to cilium/cilium
that referenced
this pull request
Jan 5, 2022
[ upstream commit ddb5482 ] Move the fork of controller-tools from my personal fork to be officially part of the Cilium repo. Along the way, add the commit from christarazi/controller-tools#1 to the v0.6.2 branch. Signed-off-by: Chris Tarazi <chris@isovalent.com> Signed-off-by: Chris Tarazi <chris@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of kubernetes-sigs#595 until it is merged upstream and this fork is rebased on top.
Also see cilium/cilium#17190 (comment) and cilium/cilium#17322 for context.
The Go team has started the process of replacing the old "// +build"
constraints with the new "//go:build" constraints. See the design
doc for more details here:
https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md
What is relevant is that in Go 1.17, gofmt now synchronizes the two
styles. In particular, if gofmt is run against a deepcopy generated
file, it will add a new "//go:build" constraint.
See https://golang.org/doc/go1.17#gofmt for details.
This PR intends to make it so that the generated code is compliant with
the new gofmt style.