Skip to content

Remove covg test folders #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chinglee-iot merged 2 commits into from
Feb 9, 2023
Merged

Remove covg test folders #5

chinglee-iot merged 2 commits into from
Feb 9, 2023

Conversation

@chinglee-iot
Copy link
Owner

@chinglee-iot chinglee-iot commented Feb 9, 2023 •
edited
Loading

Remove covg test folders

Description

  • Remove multiple_priorities_no_timeslice_covg, single_priority_no_timeslice_covg and single_priority_timeslice_thread test folders
  • Move the covg test to the folder with same FreeRTOSConfig.h
  • Add configUSE_TICKLESS_IDLE config in single_priority_no_timeslice test group
  • The pthread will be removed in another PR
Filename Line Coverage -- Functions -- Branches --
event_groups.c 94.1 % 177 / 188 100.0 % 15 / 15 70.2 % 66 / 94
list.c 100.0 % 41 / 41 100.0 % 5 / 5 100.0 % 6 / 6
queue.c 95.3 % 710 / 745 100.0 % 46 / 46 97.0 % 446 / 460
stream_buffer.c 100.0 % 319 / 319 100.0 % 25 / 25 94.8 % 182 / 192
tasks.c 88.3 % 1355 / 1534 100.0 % 94 / 94 74.0 % 741 / 1002
timers.c 100.0 % 237 / 237 100.0 % 29 / 29 96.1 % 74 / 77

Test Steps

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chinglee-iot chinglee-iot requested a review from joshzarr February 9, 2023 03:50
@chinglee-iot
Remove covg test folders
7b434a1 
* Move the covg test to the folder have same FreeRTOSConfig.h
* Add configUSE_TICKLESS_IDLE config in single_priority_no_timeslice test group
@joshzarr
Copy link
Collaborator

joshzarr commented Feb 9, 2023

Changes look good!
Verified test coverage target runs as expected.
Approved to merge as is

Open question:
I noticed there is still a single_priority_timeslice_thread folder. Did you also want to move that file/folder as part of this PR or handle it in a future PR?

@chinglee-iot
Remove single_priority_timeslice_thread
8b9f6e3 
* Move the utest.c file to single_priority_timeslice folder
@chinglee-iot
Copy link
Owner Author

chinglee-iot commented Feb 9, 2023

Changes look good! Verified test coverage target runs as expected. Approved to merge as is

Open question: I noticed there is still a single_priority_timeslice_thread folder. Did you also want to move that file/folder as part of this PR or handle it in a future PR?

Originally, I plan to remove this folder as well as pthread in one PR.
I think we can remove the folder first and remove the pthread in another PR.
single_core_covg will be remove in pthread PR as the we can not just move the utest.c file to tasks folder.

@chinglee-iot chinglee-iot merged commit d79a533 into smp-unit-test-covg Feb 9, 2023
@chinglee-iot chinglee-iot deleted the remove-covg-folders branch February 9, 2023 15:41
alfred2g pushed a commit that referenced this pull request Feb 10, 2023
@chinglee-iot @alfred2g
Remove covg test folders (#5)
f84239a 
* Remove multiple_priorities_no_timeslice_covg, single_priority_no_timeslice_covg and single_priority_timeslice_thread test folders and move the covg utest.c to the folder with same FreeRTOSConfig.h
* Add configUSE_TICKLESS_IDLE config in single_priority_no_timeslice test group
* Add configUSE_MINIMAL_IDLE_HOOK config in single_priority_timeslice test group
chinglee-iot pushed a commit that referenced this pull request May 20, 2025
@ActoryOu @pranjalchanda08 @aggarg
Fix RP2040 compile warning (FreeRTOS#736)
dd1b87d 
* Fix Pico compile warning -- port layer

* Warning resolved for volatile discard task.c (#5)

---------

Co-authored-by: Pranjal Chanda <40349163+pranjalchanda08@users.noreply.github.com>
Co-authored-by: Gaurav-Aggarwal-AWS <33462878+aggarg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshzarr joshzarr joshzarr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chinglee-iot @joshzarr