Skip to content

Update AUTHORIZE_UPGRADE_PREFIX#64

Merged
chevdor merged 2 commits intochevdor:masterfrom
aurexav:master
Apr 13, 2023
Merged

Update AUTHORIZE_UPGRADE_PREFIX#64
chevdor merged 2 commits intochevdor:masterfrom
aurexav:master

Conversation

@aurexav
Copy link
Contributor

@aurexav aurexav commented Mar 14, 2023

Adapt https://github.com/paritytech/cumulus/blob/bbb2c6cb25a511f1296b431833e52c4d965e01d8/pallets/parachain-system/src/lib.rs#L468.

Sorry, I found there was already a #62.

But I also update the test cases and the docs.

@chevdor

@chevdor
Copy link
Owner

chevdor commented Apr 13, 2023

Thanks for the PR, could you merge #62 in your PR so we have everything in one place ?

The main difference is the use of a const so we have the 0x02 value in one single place.

Copy link
Owner

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge #62 so we can close #62 and focus on #64.
The const introduced in #62 could become helpful.

@aurexav
Copy link
Contributor Author

aurexav commented Apr 13, 2023

Please merge #62 so we can close #62 and focus on #64. The const introduced in #62 could become helpful.

Thanks for the PR, could you merge #62 in your PR so we have everything in one place ?

The main difference is the use of a const so we have the 0x02 value in one single place.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants