Issue #14448: Migrate IDEA to highest true-scopes release v2022.3.3#846
Conversation
|
@romani , |
|
checkstyle/checkstyle#14696 (comment) Looks like it is not working. |
|
@romani , I see that the image is building ?
I meant we had a bit more violations to suppress than the latest release that we previously worked on.. |
|
@romani , ping please |
nrmancuso
left a comment
There was a problem hiding this comment.
How do we know that we won't run into more issues with this version without having addressed all inspections?
This comment was marked as outdated.
This comment was marked as outdated.
|
https://github.com/checkstyle/checkstyle/pull/14696/files has only an updated image with failing CI.
Reply at #846 (comment) does not answer this question. Detailed explanations and "should" do not give me confidence; green CI does. I would expect a PR with green CI to show that this image will work for us. |
|
I am placing a blocked label on this until we work out which version we need to use. |
|
@romani , @nrmancuso , CI at checkstyle/checkstyle#14696 are green now. The PR has been updated for description, commit msg and suppressions resulting with new image. |
romani
left a comment
There was a problem hiding this comment.
Ok to merge, small step but good step.
|
@MANISH-K-07 , please report to jetbrains a version where scope becomes broken, it will help them |
@romani , already posted updates in issue tracker yesterday itself😄 Please let me know if that comment could be enhanced in anyway to help them better.... |
Aims to close checkstyle/checkstyle#14448
Follow-up of checkstyle/checkstyle#14604 and #837
Based on observations from checkstyle/checkstyle#14604 (comment) and further discussions.
last time we upgraded
2022.2.2->2023.3.4at80a6139 , but latest is problematic with scopes.
The latest IDEA release that we have used for update (2023.3.4) had issues with scopes.
A bit of research on different versions landed me on
v2022.3.3being stable and good with scopes.Link to PR in Checkstyle main repo with updated docker image : checkstyle/checkstyle#14696
Link to docker image (personal) for testing update :
https://hub.docker.com/layers/manishkk07/manish-k-07-checkstyle/jdk11-idea2022.3.3/images/sha256-3a659714655f8e033e648d894ac20eb110a0aa557f0f19821366cb54e4089305?context=repo
To pull image :
docker pull manishkk07/manish-k-07-checkstyle:jdk11-idea2022.3.3