@romani , @nrmancuso

We have UnusedProperty firing violations on properties files.
Any suggestions on how we might suppress these? (instead of disabling the validation which is worst case alternative)

from CI:

<problem>
<file>
file://$PROJECT_DIR$/src/test/resources/com/puppycrawl/tools/checkstyle/main/
InputMainPropertyChainingUndefinedProperty.properties
</file>
<line>1</line>
<module>checkstyle</module>
<entry_point TYPE="file" FQNAME="file://$PROJECT_DIR$/src/test/resources/
com/puppycrawl/tools/checkstyle/main/InputMainPropertyChainingUndefinedProperty.properties"/>
<problem_class id="UnusedProperty" severity="ERROR" attribute_key="ERRORS_ATTRIBUTES">
Unused property</problem_class>
<description>Unused property 'mycheckstyle.severity'</description>
<highlighted_element>mycheckstyle.severity</highlighted_element>
<language>Properties</language>
<offset>0</offset>
<length>21</length>
</problem>
<problem>

it is again scope problems. Inputs should not be validated, as they weird by design.

<problems is_local_tool="true">
<problem>
<file>
file://$PROJECT_DIR$/src/test/resources/simplelogger.properties
</file>
<line>2</line>
<module>checkstyle</module>
<entry_point TYPE="file" FQNAME="file://$PROJECT_DIR$/src/test/resources/simplelogger.properties"/>
<problem_class id="UnusedProperty" severity="ERROR" attribute_key="ERRORS_ATTRIBUTES">
Unused property</problem_class>
<description>
Unused property 'org.slf4j.simpleLogger.log.com.tngtech.archunit.core.PluginLoader'
</description>
<highlighted_element>
org.slf4j.simpleLogger.log.com.tngtech.archunit.core.PluginLoader
</highlighted_element>
<language>Properties</language>
<offset>0</offset>
<length>65</length>
</problem>
<problem>
<file>
file://$PROJECT_DIR$/src/test/resources/simplelogger.properties
</file>
<line>3</line>
<module>checkstyle</module>
<entry_point TYPE="file" FQNAME="file://$PROJECT_DIR$/src/test/resources/simplelogger.properties"/>
<problem_class id="UnusedProperty" severity="ERROR" attribute_key="ERRORS_ATTRIBUTES">
Unused property</problem_class>
<description>
Unused property 'org.slf4j.simpleLogger.log.org.reflections'
</description>
<highlighted_element>org.slf4j.simpleLogger.log.org.reflections</highlighted_element>
<language>Properties</language>
<offset>0</offset>
<length>42</length>
</problem>

this looks like false positives. As this properties are for logging library, not for Checkstyle.

@romani , Issue reported to jetBrains tracker at IDEA-351113

Shall we hold this PR meanwhile? Please let me know what you suggest?

Yes, Let's wait for their feedback.

It is sad to be blocked and not doing any progress forward.
https://www.jetbrains.com/idea/download/other.html

Did you try 2022.2.5 or 2022.3 ? At least we can upgrade to version before they damage scopes.

It is sad to be blocked and not doing any progress forward. https://www.jetbrains.com/idea/download/other.html

Did you try 2022.2.5 or 2022.3 ? At least we can upgrade to version before they damage scopes.

Yes @romani , label blocked doesn't ring good for me either :)

I will try to find another release supporting scopes, also keeping in mind the Yaml validation which is the main reason for this update.

Yaml validation instability , probably just another point to report to jetbrains

@romani , @nrmancuso , 2022.3.3 is a stable release.. highest of 2022 tag

The PR has been updated for description, commit msg and suppressions resulting with new image.
Please air the image to complete migration :)

I am ok to merge.
Let's not update container until contribution PR is merged

@MANISH-K-07 please update image tag and make CI happy

@MANISH-K-07 please update image tag and make CI happy

@nrmancuso , image updated :)

Rebased on master....

@nrmancuso , @romani , CI is green except for check_issues

@nrmancuso , @romani , CI is green except for check_issues

Ok, what do we need to do to make this green?

@nrmancuso , @romani , CI is green except for check_issues

Ok, what do we need to do to make this green?

@nrmancuso , this is irrelevant to our code changes, I believe.

However, if this doesn't give you confidence, I will explain further....
The failing CI is because of an outdated linked issue
Funny thing is that the link causing problem is mentioned in your post at #14448 (comment), so yes, not done yet 😄

We need to edit by #14448 (comment) and restart CI to see a green suite

We need to try to enable this inspection again

We need to try to enable this inspection again

Yupp, figured that out but wanted to confirm with you all @nrmancuso
#14448 (comment)

Will re-enable in new PR as minor once this is merged?
Is this commit good to merge @nrmancuso ?

Better to ree able in separate PR, and rerun CI numerous times before merge.

This PR is already big.

Better to ree able in separate PR, and rerun CI numerous times before merge.

This PR is already big.

Makes sense.. will try after this is merged :)

@MANISH-K-07 please create a new issue to track reenabling the yaml validation inspection in this repo (not contribution) and send a minor PR to update the linked issue to make CI happy while we test the fix

Sure @nrmancuso .. will do

@nrmancuso , @romani , Please see #14806