Skip to content

Issue #19737: Add validation for input files under it folder#19738

Merged
romani merged 1 commit into
checkstyle:masterfrom
lithops-zty:issue-19737-add-it-input-file-validation
Apr 22, 2026
Merged

Issue #19737: Add validation for input files under it folder#19738
romani merged 1 commit into
checkstyle:masterfrom
lithops-zty:issue-19737-add-it-input-file-validation

Conversation

@lithops-zty

Copy link
Copy Markdown
Contributor

fixes: #19737

Changes

  1. Include all java files from it/resources and it/resources-noncompilable to undergo validation;
  2. Add suppressions for existing violations.

@lithops-zty

Copy link
Copy Markdown
Contributor Author

@romani PR ready for review.
I think we should reopen issue #13213 after merging this PR.

files="[\\/]packageobjectfactory[\\/]abc[\\/]FooCheck.java"/>
<suppress id="noCheckstyleInInputs"
files="[\\/]packageobjectfactory[\\/]zoo[\\/]FooCheck.java"/>
<suppress id="UnnecessaryOkComment"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment in next PR that this block is until #19739

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in #19740

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in #19740

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to prevent leaks quicker.

@romani romani merged commit b53d8b2 into checkstyle:master Apr 22, 2026
122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Input files under it are not tested against config/checkstyle-input-checks.xml

2 participants