identified in #19651 (comment)
Problem
The config checkstyle-input-checks.xml is used in ant_phase_verify.xml to flag input files that have reference to checkstyle's own files or //ok comments without an explanation. However, currently only files under test are checked (line 208):
|
<checkstyle config="${check.config_input}" |
|
failOnViolation="true" |
|
failureProperty="checkstyle.failure.property" |
|
executeIgnoredModules="true" |
|
> |
|
<path> |
|
<fileset dir="src" |
|
includes="test/resources/**/*.java,test/resources-noncompilable/**/*.java"> |
This misses input files under it. Consequently, //ok comments without explanations in these files are silently passed during CI.
identified in #19651 (comment)
Problem
The config
checkstyle-input-checks.xmlis used inant_phase_verify.xmlto flag input files that have reference to checkstyle's own files or//okcomments without an explanation. However, currently only files undertestare checked (line 208):checkstyle/config/ant-phase-verify.xml
Lines 201 to 208 in 55c213d
This misses input files under
it. Consequently,//okcomments without explanations in these files are silently passed during CI.