Issue #19188: fix compilation comments to Java25 and add CI check for noncompilable inputs#19564
Merged
romani merged 1 commit intoApr 2, 2026
Conversation
Contributor
Author
|
@romani let me know if any other change needed |
romani
requested changes
Apr 2, 2026
| ;; | ||
|
|
||
| check-no-java21-noncompilable) | ||
| files=($(grep -Rli --include='*.java' ': Compilable with Java21' \ |
Member
There was a problem hiding this comment.
I don't think we need this.
Can you update javac --release 21 --enable-preview
To remove preview flag.
We don't support previews at all, no preview anymore.
We can remove such flag from all javac jobs
… check to prevent Java21 comments
542784e to
f8b8752
Compare
Contributor
Author
|
@romani done, let me know if any other change needed |
stoyanK7
approved these changes
Apr 2, 2026
stoyanK7
left a comment
Collaborator
There was a problem hiding this comment.
Looks good 👍
In response to #19551 (comment)
hi @stoyanK7 , thanks for the review, i've addressed both your points, please let me know if u still face the error, or if there any else change needed
I've tested the following flow:
- Clone Checkstyle
./mvnw clean install- Open in IntelliJ IDEA
- Run
SuppressWithNearbyTextFilterTestvia the IDERun Testsbutton
Tests executed with no compilation errors. So starting development should now be smoother
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19551, fixes #19188
-> changed
// non-compiled with javac: Compilable with Java21to// non-compiled with javac: Compilable with Java25in 16 xdocs example files-> removed
--enable-previewflag from all javac jobs (17, 19, 20, 21, 22, 25)in
.ci/validation.sh