Issue #19188: Move non-compilable Input files to resources-noncompilable folders#19551
Merged
romani merged 1 commit intoApr 2, 2026
Conversation
579a1a0 to
a9b181d
Compare
Collaborator
|
Github, generate site |
Collaborator
|
I checked out this PR branch and ran a random test locally via IDEA. This is the result: Could you please check locally if you get the same compilation error on these files? If so, please move these 8 files to their respective |
stoyanK7
suggested changes
Apr 1, 2026
Comment on lines
+107
to
+123
| <!-- Suppress for non-compilable xdocs example filesets moved from resources --> | ||
| <suppress id="presenceOfCompilationComment" | ||
| files="finallocalvariable[\\/].*"/> | ||
| <suppress id="presenceOfCompilationComment" | ||
| files="missingnullcaseinswitch[\\/].*"/> | ||
| <suppress id="presenceOfCompilationComment" | ||
| files="patternvariableassignment[\\/].*"/> | ||
| <suppress id="presenceOfCompilationComment" | ||
| files="unusedcatchparametershouldbeunnamed[\\/].*"/> | ||
| <suppress id="presenceOfCompilationComment" | ||
| files="unusedlambdaparametershouldbeunnamed[\\/].*"/> | ||
| <suppress id="presenceOfCompilationComment" | ||
| files="unusedlocalvariable[\\/].*"/> | ||
| <suppress id="presenceOfCompilationComment" | ||
| files="whenshouldbeused[\\/].*"/> | ||
| <suppress id="presenceOfCompilationComment" | ||
| files="finalparameters[\\/].*"/> |
Collaborator
There was a problem hiding this comment.
Instead of suppressing this absence of a compilation comment, please add instead a compilation comment to each file:
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/finallocalvariable/Example1.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/finallocalvariable/Example2.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/finallocalvariable/Example3.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/finallocalvariable/Example4.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/finallocalvariable/Example5.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/missingnullcaseinswitch/Example1.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/patternvariableassignment/Example1.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/unusedcatchparametershouldbeunnamed/Example1.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/unusedlambdaparametershouldbeunnamed/Example1.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/unusedlocalvariable/Example1.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/unusedlocalvariable/Example2.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/whenshouldbeused/Example1.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/finalparameters/Example1.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/finalparameters/Example2.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/finalparameters/Example3.java:1: Missing compilation comment [presenceOfCompilationComment]
[ERROR] [checkstyle] [ERROR] /tmp/checkstyle/src/xdocs-examples/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/finalparameters/Example4.java:1: Missing compilation comment [presenceOfCompilationComment]
Member
There was a problem hiding this comment.
Why suppression?
We should put comment in them
a9b181d to
110af6d
Compare
Contributor
Author
|
hi @stoyanK7 , thanks for the review, i've addressed both your points, please let me know if u still face the error, or if there any else change needed |
b75617c to
4e1f62b
Compare
4e1f62b to
54360c7
Compare
Member
romani
approved these changes
Apr 2, 2026
romani
left a comment
Member
There was a problem hiding this comment.
There are bunch of items to improve, but let me merge this as first big step and
In follow up PR we will fix details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19188
->moved java 21+ input files from
src/test/resources/tosrc/test/resources-noncompilable/->moved java 21+ input files from
src/it/resources/tosrc/it/resources-noncompilable/->moved xdocs example files from
src/xdocs-examples/resources/tosrc/xdocs-examples/resources-noncompilable/->updated related test files to use
getNonCompilablePath()instead of
getPath()->updated the affected
*.xml.templatefiles with the right paths->added // non-compiled with javac: compilable with Java21 comments to xdocs example files