Issue #17052: Flexible constructor bodies support#19364
Merged
Conversation
5bc2c38 to
7df583a
Compare
Contributor
Author
|
Added InputFlexibleConstructorBodyWithRecord file for addressing #19342 |
Merged
5716679 to
b46640f
Compare
Contributor
Author
Contributor
Author
|
Ci failure is flaky, not related to code changes |
Contributor
Author
Member
|
@mahfouz72 , @vivek-0509 , please evaluate this achievement |
mahfouz72
suggested changes
May 13, 2026
Member
|
@romani We have another PR for the same issue: checkstyle/checkstyle#18821. However, I think this PR is closer to being merged since we already have the diff report. |
eece899 to
f2e4d32
Compare
Contributor
Author
|
@mahfouz72 Made all changes. Failures in test are not code induced |
mahfouz72
suggested changes
May 14, 2026
a59e027 to
d2bde2c
Compare
mahfouz72
approved these changes
May 15, 2026
mahfouz72
left a comment
Member
There was a problem hiding this comment.
Thanks a lot!
Single commit please
Contributor
Author
Oh I messed that up from reverting some things. Thanks for reviewing the PR! |
Member
|
@vivek-0509 , please review. |
romani
approved these changes
May 15, 2026
romani
left a comment
Member
There was a problem hiding this comment.
Done cleanly, nothing to improve.
4 tasks
Contributor
Author
|
Thank you everyone for the hardwork! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #17052: Flexible constructor bodies support
Fixes #17052 and #19342. Both are similar in nature and are fixed by code changes.
#19342 test case
src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/grammar/java25/InputFlexibleConstructorBodyWithRecord.javais faithfully reproduced and causes no issues.