Issue #17052: Fix CI failures for Flexible constructor bodies#18821
Closed
vad0 wants to merge 1 commit into
Closed
Issue #17052: Fix CI failures for Flexible constructor bodies#18821vad0 wants to merge 1 commit into
vad0 wants to merge 1 commit into
Conversation
95e8688 to
bfc7879
Compare
Member
|
@mahfouz72 , please review this PR. Hint: our grammar can be more relaxed than java grammar, we always executed on fully compiled sources. |
Member
|
Single commit please |
ba56d1b to
bce381d
Compare
Member
|
please follow CI, extra fix is required. |
fef4414 to
f7c97ba
Compare
Author
|
will it be merged? |
Author
Member
|
@mahfouz72 , @vivek-0509 , please review. |
mahfouz72
suggested changes
May 3, 2026
| @@ -0,0 +1,69 @@ | |||
| // Java25 | |||
Member
There was a problem hiding this comment.
This file will not be picked up by the javac25 job. please change
Suggested change
| // Java25 | |
| // non-compiled with javac: Compilable with Java25 |
| </module> | ||
|
|
||
| <!-- until https://github.com/checkstyle/checkstyle/issues/17052 --> | ||
| <module name="BeforeExecutionExclusionFileFilter"> |
Member
There was a problem hiding this comment.
We should remove the exclusions now, not the comment only. Please do so that the no-exception-openjdk25 picks those files in the next runs.
Member
|
Please generate an ANTLR regression report |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javac17_standardCI failure by changing comment pattern in test files from// non-compiled with javac:to// Java25ExpectedFlexibleConstructorBody.txtwith correct column positions after rebasing onto masterThis PR builds on #17982 by rebasing onto current master and fixing the CI failures.
Changes
InputFlexibleConstructorBodyWithNestedClass.java- Changed comment to prevent javac17 compilationInputFlexibleConstructorBodyWithReturn.java- Changed comment to prevent javac17 compilationExpectedFlexibleConstructorBody.txt- Regenerated with correct 1-based column positionsTest plan
Java25AstRegressionTestpasses (3 tests)JavaAstVisitorTestpasses (5 tests)IndentationCheckTestpasses (194 tests)Resolves #17052
🤖 Generated with Claude Code