Skip to content

Pull #18795: Dedicate rewrite recipes#18795

Merged
romani merged 1 commit into
checkstyle:masterfrom
Pankraz76:fix-AutoFixesPart1-reorgnization-rw
Jan 31, 2026
Merged

Pull #18795: Dedicate rewrite recipes#18795
romani merged 1 commit into
checkstyle:masterfrom
Pankraz76:fix-AutoFixesPart1-reorgnization-rw

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Jan 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Pull #18795: Dedicate rewrite recipes #18794 #18673 #18791

@Pankraz76 Pankraz76 changed the title Fix auto fixes part1 reorgnization rw Pull #18795: Dedicate rewrite recipes #18794 #18673 #18791 Jan 30, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…
d853da4 
…kstyle#18673 checkstyle#18791
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
@Pankraz76
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…
fec1bab 
…kstyle#18673 checkstyle#18791
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from d853da4 to fec1bab Compare January 30, 2026 12:11
@Pankraz76 Pankraz76 marked this pull request as ready for review January 30, 2026 12:11
@Pankraz76 Pankraz76 mentioned this pull request Jan 30, 2026
Closed
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…
ce3831f 
…kstyle#18673 checkstyle#18791
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from fec1bab to ce3831f Compare January 30, 2026 12:12
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…
c4a9fa9 
…kstyle#18673 checkstyle#18791
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from ce3831f to c4a9fa9 Compare January 30, 2026 12:12
Pankraz76
Pankraz76 commented Jan 30, 2026
View reviewed changes
Comment thread config/rewrite.yml
romani
romani requested changes Jan 30, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

Comment thread .ci/validation.sh Outdated
Comment thread .ci/validation.sh Outdated
Comment thread .ci/validation.sh Outdated
Comment thread .circleci/config.yml Outdated
Comment thread .ci/validation.sh
@Pankraz76 Pankraz76 requested a review from romani January 30, 2026 12:19
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…
9f7f423 
…kstyle#18673 checkstyle#18791
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from c4a9fa9 to 9f7f423 Compare January 30, 2026 12:24
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…
65e2254 
…kstyle#18673 checkstyle#18791
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from 9f7f423 to 65e2254 Compare January 30, 2026 12:25
@Pankraz76

Pankraz76 commented Jan 30, 2026

Copy link
Copy Markdown
Author

kindly reconsider.

@Pankraz76

Pankraz76 commented Jan 30, 2026

Copy link
Copy Markdown
Author

yes we need as build need this

Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact com.puppycrawl.tools:checkstyle-openrewrite-recipes:jar:1.0.0-SNAPSHOT in nexus-codehaus-snapshot (https://oss.sonatype.org/content/repositories/codehaus-snapshots/)

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…
a9d4a5a 
…kstyle#18673 checkstyle#18791
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from 65e2254 to a9d4a5a Compare January 30, 2026 12:48
@Pankraz76

Pankraz76 commented Jan 30, 2026

Copy link
Copy Markdown
Author

lets merge first and then reconsider this we doing too much offtopic...

@Pankraz76

Pankraz76 commented Jan 30, 2026

Copy link
Copy Markdown
Author

yes we need as build need this

Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact com.puppycrawl.tools:checkstyle-openrewrite-recipes:jar:1.0.0-SNAPSHOT in nexus-codehaus-snapshot (https://oss.sonatype.org/content/repositories/codehaus-snapshots/)

actually strange no body has this locally so why its doing so?

we dont want to dedicate config into profile thats too much for this tmp approach.

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…
e9b341b 
…kstyle#18673 checkstyle#18791
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from a9d4a5a to e9b341b Compare January 30, 2026 12:57
@Pankraz76 Pankraz76 mentioned this pull request Jan 30, 2026
Closed
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in OpenRew…
a9b9bd2 
…rite CI checkstyle#18673 checkstyle#18795
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…
96caae6 
…kstyle#18673 checkstyle#18791
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from e9b341b to 96caae6 Compare January 30, 2026 13:15
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in OpenRew…
51bb07b 
…rite CI checkstyle#18673 checkstyle#18795
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from 996222b to 3fef37b Compare January 30, 2026 15:02
Pankraz76
Pankraz76 commented Jan 30, 2026
View reviewed changes
Comment thread pom.xml Outdated
<skipMavenParsing>true</skipMavenParsing>
<activeRecipes>
<recipe>org.checkstyle.AllAutoFixes</recipe>
<recipe>org.checkstyle.CheckstyleAutoFix</recipe>

@Pankraz76 Pankraz76 Jan 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could tmp diable but behaviour was the same so its both considerable

@Pankraz76 Pankraz76 changed the title Pull #18795: Dedicate rewrite recipes #18794 #18673 #18791 Pull #18795: Dedicate rewrite recipes #18794 #18673 #18791 Jan 30, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 ch…
63d61ff 
…eckstyle#18673 checkstyle#18791
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from 3fef37b to 63d61ff Compare January 30, 2026 15:14
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
e87a4dc 
…write` CI checkstyle#18673 checkstyle#18795
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 ch…
4d037fd 
…eckstyle#18673 checkstyle#18791
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from 63d61ff to 4d037fd Compare January 30, 2026 15:41
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 ch…
086a9c4 
…eckstyle#18673 checkstyle#18791
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
fb160d1 
…write` CI checkstyle#18673 checkstyle#18795
@Pankraz76 Pankraz76 force-pushed the fix-AutoFixesPart1-reorgnization-rw branch from 086a9c4 to da171d9 Compare January 30, 2026 15:50
@Pankraz76 Pankraz76 mentioned this pull request Jan 30, 2026
Closed
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
a4425ed 
…write` CI checkstyle#18673 checkstyle#18795
@Pankraz76

Pankraz76 commented Jan 30, 2026

Copy link
Copy Markdown
Author

lets merge this and then good 2 go.

romani
romani approved these changes Jan 31, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items for next update

Comment thread config/rewrite.yml
@@ -1,21 +1,46 @@
---
type: specs.openrewrite.org/v1beta/recipe
# seems smell, as pom declaration not working...

@romani romani Jan 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this in next PR

@romani romani merged commit 30a2615 into checkstyle:master Jan 31, 2026
121 checks passed
@github-actions github-actions Bot added this to the 13.1.0 milestone Jan 31, 2026
@romani romani changed the title Pull #18795: Dedicate rewrite recipes #18794 #18673 #18791 Pull #18795: Dedicate rewrite recipes Jan 31, 2026
romani pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 31, 2026
@romani
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
2b1165c 
…write` CI checkstyle#18673 checkstyle#18795
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 31, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
53af05b 
…write` CI checkstyle#18673 checkstyle#18795
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 31, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
589e851 
…write` CI checkstyle#18673 checkstyle#18795
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 31, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
ab8ea4e 
…write` CI checkstyle#18673 checkstyle#18795
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 31, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
2b51b60 
…write` CI checkstyle#18673 checkstyle#18795
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 31, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
8b4ec2e 
…write` CI checkstyle#18673 checkstyle#18795
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 31, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
a470d74 
…write` CI checkstyle#18673 checkstyle#18795
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 31, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
f7ad66c 
…write` CI checkstyle#18673 checkstyle#18795
@Pankraz76 Pankraz76 mentioned this pull request Feb 1, 2026
Closed
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026
Issue checkstyle#18789: Activate Java 21 migration recipes in `OpenRe…
7f95e75 
…write` CI checkstyle#18673 checkstyle#18795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

miscellaneous

Projects

None yet

Milestone

13.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @romani