Pull #18746: Add failOnDryRunResults to fix rewrite feature envy #18746
Pull #18746: Add failOnDryRunResults to fix rewrite feature envy #18746Pankraz76 wants to merge 1 commit into
failOnDryRunResults to fix rewrite feature envy #18746Conversation
failOnDryRunResults to fix rewritefailOnDryRunResults to fix rewrite
|
|
||
| echo "Running Checkstyle validation to get report for openrewrite..." | ||
| echo "Installed checkstyle-openrewrite-recipes.jar, remove obsolete tmp dir..." | ||
| rm -rf /tmp/checkstyle-openrewrite-recipes |
There was a problem hiding this comment.
lets make it clear and use rewrite like its supposed to. no feature envy anymore having cost of carry. This way its done like for customers.
| PROJECT_ROOT="$(pwd)" | ||
| export MAVEN_OPTS="-Xmx4g -Xms2g" | ||
|
|
||
| cd /tmp |
There was a problem hiding this comment.
yes having tmp is kind of nice and the way 2 do. maybe make it even .tmp to really hide it. But if there is an collision its there anyways so imho no need. also we delete this dir right after usage. its gone right after the install.
@Pankraz76 Stop. You can't go around calling maintainers "not smart enough" or "does not grasp simple issues anymore". Nor can you call a way that works for folks "feature envy" when then might not have been aware of the options available to them. If you want to meaningfully contribute somewhere it's up to you to clearly outline your idea, and propose it in a way that folks are likely to agree with and adopt. Consider that folks might not be aware of something, and educate them with kindness. You might find you'll have more success getting your ideas adopted. More broadly I've seen this type of dynamic from you play out across a number of projects now. Such negative messages are hurting maintainers who put their private time and effort into a project. And on a personal level it pains me that the way folks learn about OpenRewrite is from insistent messaging. I ask that you take a good step back, reflect, and either thoroughly adjust your tone or refrain from posting to projects. To @romani: I'm sorry to see how this has played out; know that I don't agree with the messaging here, but have no control over what our users might do with our tooling. Know that I'm always happy to help where I can, and I wish you all the best. |
told them many times before..l i can understand you. still this my opinion and nothing more. Does not need to be right or wrong. Also you do not say one technincal argument this kind of weak too. you focusing too much on emotions. its nothing personal and might be lost in translation. |
|
@Pankraz76, please stop mentioning other peoples in checkstyle PRs. I defining rules in this project, I know what is working well for us, and I will be done in way it works for us, not in way how worked in some other place. If you didn't switch your activity to comply our rules , I will have to ban you. |
|
I don't see a reason of this update. Whole CI works in simple concept: run command, fix violations or apply suggested code changes. |
|
this way is faster and simpler for the users. |
Pull #18746: Add
failOnDryRunResultsto fix rewrite feature envybenefit;
let user know what to do: