Issue #18612: Remove redundant tokens property from CustomImportOrder in google_checks.xml#18651
Merged
romani merged 1 commit intoFeb 5, 2026
Conversation
Member
|
@pirzada-ahmadfaraz , please update commit message to follow our requirements. thanks a lot for your help |
936cd1a to
11aed7b
Compare
Contributor
Author
|
Rebased on latest master. Build passes locally (tests skipped due to Java 25/Mockito incompatibility on my machine, but CI uses JDK 21). |
Member
|
Please read https://ci.appveyor.com/project/Checkstyle/checkstyle/builds/53468175/job/n1qtbhmyi8p1o744#L1277 |
Contributor
|
@pirzada-ahmadfaraz this is the issue of ci failure fix this then ci will pass. |
11aed7b to
aee4e8a
Compare
…mportOrder in google_checks.xml
aee4e8a to
f2f6b87
Compare
Contributor
Author
|
@romani all good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18612
Summary
The
tokensproperty was dropped fromCustomImportOrderin #12145. SincegetAcceptableTokens()returnsgetRequiredTokens(), the tokens cannot be customized - they are fixed toIMPORT,STATIC_IMPORT, andPACKAGE_DEF.The
tokensproperty ingoogle_checks.xmlhas no effect and should be removed.Changes
Removed the redundant line: