Skip to content

ImportOrder: tokens property should be not customizable, move STATIC_IMPORT to required tokens #12145

@rnveach

Description

@rnveach

Identified at #3955 ,

https://checkstyle.org/config_imports.html#ImportOrder_Properties

There are no examples or explanation from what STATIC_IMPORT gives you in this check.
It is enabled by default, but what happens if you disable it, if its possible. It is also not clear how it can be disabled in configuration, which I assume involves setting the property to an empty string.

We should examine what this token does, if it should remain optional, and update the xdoc based on the findings.

User Migration

As all tokens were made required, users can either remove the tokens property for the check. Leaving it alone will also have no side effects as there is no way to override required tokens.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions