Skip to content

Issue #18034: Resolve Pitest Suppressions - imports#18565

Merged
romani merged 1 commit into
checkstyle:masterfrom
Youssefalaa7:issue-18034-Resolve-Pitest-Suppressions-imports
Jan 9, 2026
Merged

Issue #18034: Resolve Pitest Suppressions - imports#18565
romani merged 1 commit into
checkstyle:masterfrom
Youssefalaa7:issue-18034-Resolve-Pitest-Suppressions-imports

Conversation

@Youssefalaa7

@Youssefalaa7 Youssefalaa7 commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #18034: Resolve-Pitest-Suppressions-imports

@Youssefalaa7 Youssefalaa7 force-pushed the issue-18034-Resolve-Pitest-Suppressions-imports branch 2 times, most recently from fe5d189 to ae31a59 Compare January 9, 2026 04:32

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

@@ -1,11 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>
<suppressedMutations>
<mutation unstable="false">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep file,and just remove mutation tag

@Youssefalaa7 Youssefalaa7 Jan 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i made this before and it gave error in [ci/circleci: openrewrite-recipes] so i though that because of not deleting the pitest file so i deleted it and it passed in current run or the error is not related to file existing or no

@romani romani Jan 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to read error message, it was likely a timeout . Unrelated error, happens in other PRs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you i revised the error and it was a timeout yes

@Youssefalaa7 Youssefalaa7 force-pushed the issue-18034-Resolve-Pitest-Suppressions-imports branch from ae31a59 to b94959b Compare January 9, 2026 05:11

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge if CI pass.

Thanks a lot!!!

@Atharv3221

Copy link
Copy Markdown
Contributor

@romani
All suppressions added in #16944 can be solved by this way.

@romani romani merged commit 7f6c832 into checkstyle:master Jan 9, 2026
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve Pitest Suppressions - imports

3 participants