Skip to content

Issue #14019: update SuppressFilterElement constructor and remove unused methods#16944

Merged
romani merged 1 commit into
checkstyle:masterfrom
Brijeshthummar02:SuppressFilterElement
Apr 25, 2025
Merged

Issue #14019: update SuppressFilterElement constructor and remove unused methods#16944
romani merged 1 commit into
checkstyle:masterfrom
Brijeshthummar02:SuppressFilterElement

Conversation

@Brijeshthummar02

@Brijeshthummar02 Brijeshthummar02 commented Apr 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #16937
Revert PR - Issue #14019
Reference #16938
Closes #16938 , #16945

Build status

mvn -e --no-transfer-progress -P"pitest-tree-walker" clean test-compile org.pitest:pitest-maven:mutationCoverage

Screenshot 2025-04-24 224939

Report

Screenshot 2025-04-24 230024

Screenshot 2025-04-24 230234

@Brijeshthummar02 Brijeshthummar02 changed the title refactor: update SuppressFilterElement constructor and remove unused methods Minor Issue #14019: update SuppressFilterElement constructor and remove unused methods Apr 24, 2025
@Brijeshthummar02 Brijeshthummar02 changed the title Minor Issue #14019: update SuppressFilterElement constructor and remove unused methods Issue #14019: update SuppressFilterElement constructor and remove unused methods Apr 25, 2025
romani
romani approved these changes Apr 25, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not explain why this extra pitest mutation shows up
But we need to merge to make CI green

@romani romani merged commit 5d33265 into checkstyle:master Apr 25, 2025
@Atharv3221

Atharv3221 commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

@romani @Brijeshthummar02

I got it you added suppressions for ci for pitest which were showing up unnecessary but why you reverted the changes in SuppressFilterElement and added the killed mutations again ?

@Brijeshthummar02

Brijeshthummar02 commented Apr 25, 2025

Copy link
Copy Markdown
Contributor Author

@romani @Brijeshthummar02

I got it you added suppressions for ci for pitest which were showing up unnecessary but why you reverted the changes in SuppressFilterElement and added the killed mutations again ?

Main reason behind this PR was to fix the pitest ci checks somehow. which was failing for every user whether they make changes related to it or not. I followed pipeline and made appropriate changes.

@romani

romani commented Apr 25, 2025

Copy link
Copy Markdown
Member

@Atharv3221, please send PR to return your changes.

@Rohanraj123

Rohanraj123 commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

I can not explain why this extra pitest mutation shows up But we need to merge to make CI green

Just a mind dump. I think due to some change, PITEST is having extra coverage in places where It was not taking a look before . But still not sure why it is just warning about valueOf func.

@Atharv3221 Atharv3221 mentioned this pull request Apr 26, 2025
Merged
@Brijeshthummar02 Brijeshthummar02 deleted the SuppressFilterElement branch August 3, 2025 08:25
@Atharv3221 Atharv3221 mentioned this pull request Jan 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

All Pitest CIs fail even when no code changes are made

4 participants

@Brijeshthummar02 @Atharv3221 @romani @Rohanraj123