Skip to content

Revert "Issue #14019: Covered pitest survivals for SuppressFilterElement"#16938

Closed
romani wants to merge 1 commit into
masterfrom
revert-16840-pitestSolving6
Closed

Revert "Issue #14019: Covered pitest survivals for SuppressFilterElement"#16938
romani wants to merge 1 commit into
masterfrom
revert-16840-pitestSolving6

Conversation

@romani

@romani romani commented Apr 23, 2025

Copy link
Copy Markdown
Member

Reverts #16840

@Abdelrhmansersawy

Abdelrhmansersawy commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

Still pitest (Header) broke on the same mutation.

Now pitest (coding) also broke.

@Praveen7294

Praveen7294 commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

I am also getting failed checks related to Pitest/test on my latest PR. Let's merge this PR first; I guess the issue will be resolved afterward.

@romani

romani commented Apr 23, 2025

Copy link
Copy Markdown
Member Author

I am afk, do you have same problem on local?

@mahfouz72

Copy link
Copy Markdown
Member

@romani, There is a change in pitest behavior without a corresponding version bump!?

All new surviving mutations of this description
<description>removed call to java/lang/String::valueOf</description>

on code like:
throw new IllegalArgumentException("Unknown type " + ast);

@Praveen7294

Copy link
Copy Markdown
Contributor

I am afk, do you have same problem on local?

No, project build successfully on local

image

@mahfouz72

Copy link
Copy Markdown
Member

Pitest will not be running in mvn verify phase.

You should use these commands:

mvn -e --no-transfer-progress -P"pitest-tree-walker" clean test-compile org.pitest:pitest-maven:mutationCoverage
groovy .ci/pitest-survival-check-xml.groovy "pitest-tree-walker"

replace pitest-tree-walker with the target profile.

@Praveen7294

Copy link
Copy Markdown
Contributor

@mahfouz72 can you help me with this problem,

Groovy version - 4.0.21

when i try to get list of profiles using below command:
groovy .ci/pitest-survival-check-xml.groovy --list

i get error:

F:\GitHub\checkstyle>groovy .ci/pitest-survival-check-xml.groovy --list
org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
F:\GitHub\checkstyle\.ci\pitest-survival-check-xml.groovy: 5: unable to resolve class groovy.util.slurpersupport.GPathResult
 @ line 5, column 1.
   import groovy.util.slurpersupport.GPathResult
   ^

F:\GitHub\checkstyle\.ci\pitest-survival-check-xml.groovy: 6: unable to resolve class groovy.util.slurpersupport.NodeChildren
 @ line 6, column 1.
   import groovy.util.slurpersupport.NodeChildren
   ^

2 errors

@Praveen7294

Copy link
Copy Markdown
Contributor

groovy older version is supporting

groovy - 2.5.23

@Brijeshthummar02

Brijeshthummar02 commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

@romani why we are reverting the PR #16840 ??Just curious

@Atharv3221

Copy link
Copy Markdown
Contributor

@Brijeshthummar02 generally last changes are revert, common debugging approach

@Brijeshthummar02

Copy link
Copy Markdown
Contributor

Okayyy

@Brijeshthummar02

Brijeshthummar02 commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

@romani i figured out all possible ways and almost up to solution, gone through whole codebase and pipelines and almost fixed all pitest checks - still some are left and the final fix will be updated soon within next 5-6hrs.

'Cause i am having my exams within next 2 hrs.

@Brijeshthummar02

Copy link
Copy Markdown
Contributor

@romani have a look at #14019 all ci green fixed whole pipeline and test case ci checks related to pitest which everyone was facing.

All Checks green.

@romani romani deleted the revert-16840-pitestSolving6 branch November 10, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants