Issue #14019: Covered pitest survivals for SuppressFilterElement#16840
Merged
Conversation
romani
requested changes
Apr 13, 2025
| final SuppressFilterElement filter2 = | ||
| new SuppressFilterElement(filePattern, checkPattern, messagePattern, | ||
| "module1", "1-10", "3,4"); | ||
| assertWithMessage("filter, filter2") |
Member
There was a problem hiding this comment.
Ok, good that you know what Filter elements are required to kill mutation.
But we do not allow pure unit testing anymore, sorry that there are bunch of bad examples of such testing.
Please convert such tests to have Input files with config for check+Filter to kill this mutation
Member
There was a problem hiding this comment.
Please try to use this method
94b5558 to
46614d8
Compare
Contributor
Author
|
@romani some ci checks are failing wrongly, I tried few times it gave me a vaild ci check failure + 1 ci incorrect check failure for 6 times Similar thing happened on my last PR too for once |
46614d8 to
a880da1
Compare
8fe603a to
b53cfea
Compare
b53cfea to
6247269
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #14019
Killing mutation with removing redundant code
Changes