Skip to content

Pull #18532: Add EmptyNewlineAtEndOfFile#18532

Merged
romani merged 1 commit into
checkstyle:masterfrom
Pankraz76:fix-EmptyNewlineAtEndOfFile-pr
Jan 9, 2026
Merged

Pull #18532: Add EmptyNewlineAtEndOfFile#18532
romani merged 1 commit into
checkstyle:masterfrom
Pankraz76:fix-EmptyNewlineAtEndOfFile-pr

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Jan 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Pull #18532: Add EmptyNewlineAtEndOfFile

@Pankraz76 Pankraz76 changed the title Pull #18528: Add EmptyNewlineAtEndOfFile Pull #18532: Add EmptyNewlineAtEndOfFile Jan 6, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 6, 2026
Pull checkstyle#18532: Add EmptyNewlineAtEndOfFile
7cbb95a
@Pankraz76 Pankraz76 force-pushed the fix-EmptyNewlineAtEndOfFile-pr branch from 5889ca6 to 7cbb95a Compare January 6, 2026 15:37
Pankraz76
Pankraz76 commented Jan 6, 2026
View reviewed changes

@Pankraz76 Pankraz76 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly pull this tiny effort not to waste too much attention on this 2 cents....

Comment thread config/rewrite.yml Outdated
violationReportPath: "target/cs_errors.xml"
configurationPath: "config/checkstyle-checks.xml"
propertiesPath: "config/openrewrite-recipes-checkstyle.properties"
violationReportPath: target/cs_errors.xml

@Pankraz76 Pankraz76 Jan 6, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this actually the benefit.

@romani romani Jan 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this update to separate PR or separate commit of this PR with message prefix "minor: .... "

Comment thread config/rewrite.yml
configurationPath: config/checkstyle-checks.xml
propertiesPath: config/openrewrite-recipes-checkstyle.properties
- org.openrewrite.java.RemoveUnusedImports
- org.openrewrite.java.format.EmptyNewlineAtEndOfFile

@Pankraz76 Pankraz76 Jan 6, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this covered already by spot. also we have seen this in log file already. third we not re testing thirty party imposing feature envy.

@Pankraz76 Pankraz76 marked this pull request as ready for review January 6, 2026 15:38
@Pankraz76

Pankraz76 commented Jan 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

we just need 2 know our shit not broken like currently done with PMD and prone.

Rewrite been correctly failing on:

so we good go know its working as expected.

PS:

no offence im just american english using universal simplification.

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 6, 2026
Pull checkstyle#18532: Add UpgradeToJava21 checkstyle#18528
8262226
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 6, 2026
Pull checkstyle#18532: Add UpgradeToJava21 checkstyle#18528
9f5449d
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 6, 2026
Pull checkstyle#18532: Add UpgradeToJava21 checkstyle#18528
92de185
@Pankraz76 Pankraz76 mentioned this pull request Jan 6, 2026
Closed
@Pankraz76

Pankraz76 commented Jan 6, 2026

Copy link
Copy Markdown
Author

reopen, due to 5 PR cap., after spotless fix thats more important now.

@Pankraz76 Pankraz76 closed this Jan 6, 2026
@Pankraz76

Pankraz76 commented Jan 6, 2026

Copy link
Copy Markdown
Author

@Pankraz76 Pankraz76 reopened this Jan 7, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 7, 2026
@Pankraz76
Pull checkstyle#18532: Add EmptyNewlineAtEndOfFile
114239c
@Pankraz76 Pankraz76 force-pushed the fix-EmptyNewlineAtEndOfFile-pr branch from 7cbb95a to 114239c Compare January 7, 2026 11:23
romani
romani requested changes Jan 9, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do

Comment thread config/rewrite.yml Outdated
violationReportPath: "target/cs_errors.xml"
configurationPath: "config/checkstyle-checks.xml"
propertiesPath: "config/openrewrite-recipes-checkstyle.properties"
violationReportPath: target/cs_errors.xml

@romani romani Jan 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this update to separate PR or separate commit of this PR with message prefix "minor: .... "

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 9, 2026
Pull checkstyle#18532: Add EmptyNewlineAtEndOfFile
8053486
@Pankraz76 Pankraz76 force-pushed the fix-EmptyNewlineAtEndOfFile-pr branch from 114239c to 8053486 Compare January 9, 2026 11:27
@Pankraz76 Pankraz76 requested a review from romani January 9, 2026 11:28
@Pankraz76

Pankraz76 commented Jan 9, 2026

Copy link
Copy Markdown
Author

could not be more pedantic than this way. its the right way yes, but its also very stupid.

@Pankraz76 Pankraz76 force-pushed the fix-EmptyNewlineAtEndOfFile-pr branch from 8053486 to 36fa50a Compare January 9, 2026 11:38
romani
romani approved these changes Jan 9, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@romani romani merged commit 6a27dfa into checkstyle:master Jan 9, 2026
118 of 119 checks passed
@Pankraz76

Pankraz76 commented Jan 9, 2026

Copy link
Copy Markdown
Author

thank you for not cancelling me.

@github-actions github-actions Bot added this to the 13.1.0 milestone Jan 9, 2026
@romani

romani commented Jan 9, 2026

Copy link
Copy Markdown
Member

@Pankraz76 , please keep all changes separate and with clear goal, keep scope small.

@Pankraz76

Pankraz76 commented Jan 9, 2026

Copy link
Copy Markdown
Author

yes having learned the lesson now. Its best for all.

@Pankraz76 Pankraz76 mentioned this pull request Jan 16, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

miscellaneous

Projects

None yet

Milestone

13.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @romani