Pull #18530: Fix `PMD` violations #18470 by Pankraz76 · Pull Request #18530 · checkstyle/checkstyle

Pankraz76 · 2026-01-06T15:18:50Z

Pull #18530: Fix PMD violations #18470

https://pmd.github.io/pmd/pmd_rules_java_design.html#exceptionasflowcontrol

Pankraz76 · 2026-01-06T15:19:03Z

enabler for:

PMD Tool Fails Locally but CI Doesn't Detect It #18479 #18470

Pankraz76 · 2026-01-07T11:24:50Z

[INFO] 
[INFO] --- pmd:3.28.0:check (default-cli) @ checkstyle ---
[WARNING] PMD Failure: com.puppycrawl.tools.checkstyle.AbstractAutomaticBean:243 Rule:ExceptionAsFlowControl Priority:3 Exception thrown at line 237 is caught in this block..
[WARNING] PMD Failure: com.puppycrawl.tools.checkstyle.DetailNodeTreeStringPrinter:80 Rule:UnusedPrivateMethod Priority:3 Avoid unused private methods such as 'parseJavadocAsDetailNode(String)'..
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:17 min
[INFO] Finished at: 2025-12-31T11:27:50Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.28.0:check (default-cli) on project checkstyle: PMD 7.20.0 has found 2 violations. For more details see: /home/circleci/project/target/pmd.xml -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.28.0:check (default-cli) on project checkstyle: PMD 7.20.0 has found 2 violations. For more details see: /home/circleci/project/target/pmd.xml
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:333)
    at org.apache.maven.lifecycle.inte

romani

Items

Pankraz76 · 2026-01-09T14:31:50Z

Too long with no output (exceeded 10m0s): context deadline exceeded

Pankraz76 · 2026-01-09T14:39:00Z

waiting for enabler:

Issue #17487: Extend exceeding CI job #18577

romani

iems:

Pankraz76 · 2026-01-10T10:13:01Z

-        final FileText text = new FileText(file, System.getProperty("file.encoding"));
-        return parseJavadocAsDetailNode(text.getFullText().toString());
+        final FileText fileText = new FileText(file, Charset.defaultCharset().name());
+        return (DetailNode) ParserUtil.createBlockCommentNode(fileText.getFullText().toString());


we just inlined so casting is kind of a smell, as was not needed before.

Pankraz76 · 2026-01-10T11:51:32Z

-        final FileText text = new FileText(file, System.getProperty("file.encoding"));
-        return parseJavadocAsDetailNode(text.getFullText().toString());
+        final FileText fileText = new FileText(file, Charset.defaultCharset().name());
+        return (DetailNode) ParserUtil.createBlockCommentNode(fileText.getFullText().toString());


even causing issue.

[ERROR] DetailNodeTreeStringPrinterTest.testHtmlTagCloseBeforeTagOpen:102 » ClassCast class com.puppycrawl.tools.checkstyle.DetailAstImpl cannot be cast to class com.puppycrawl.tools.checkstyle.api.DetailNode (com.puppycrawl.tools.checkstyle.DetailAstImpl and com.puppycrawl.tools.checkstyle.api.DetailNode are in unnamed module of loader 'app')

Pankraz76 · 2026-01-10T12:00:42Z

    private static DetailNode parseFile(File file) throws IOException {
-        final FileText text = new FileText(file, System.getProperty("file.encoding"));
-        return parseJavadocAsDetailNode(text.getFullText().toString());
+        return parseJavadocAsDetailNode(getBlockCommentNode(file));


not its pure functional which is the highest form of coding.

just the pure functionality, boiled down all the obsolete non-sense away.

Pankraz76 · 2026-01-10T12:02:36Z

+     * @throws IOException if the file could not be read.
+     */
+    private static DetailAST getBlockCommentNode(final File file) throws IOException {
+        return ParserUtil.createBlockCommentNode(


return new

thats the story we need to know. understanding the whole context after 2 words on dedicated abstraction layer without any obsolete coupling.

if desired then reader can continue going into details.

direct simple stupid story telling is highest form of read<bility you always demanding we i also. We both sitting in the same boat.

romani · 2026-01-11T01:42:59Z

No idea what is going on here, no reason to my mind

Pankraz76 · 2026-01-11T09:32:16Z

this codebase is broken considering PMD !!!!!!!

we not passing pmd

Pull #18529: Fix wrong test scope for PMD #18529

Pankraz76 · 2026-01-11T09:33:45Z

please consider you own CI to consider your own project.

https://app.circleci.com/pipelines/github/checkstyle/checkstyle/39785/workflows/b74d26de-055b-4cd9-9710-8933b6f18adf/jobs/1227231

Caused by: org.apache.maven.plugin.MojoFailureException: PMD 7.20.0 has found 2 violations. For more details see: /home/circleci/project/target/pmd.xml

Pankraz76 · 2026-01-11T09:34:51Z

i does not feel like im talking to the maintainer and team lead of this product but to some random bystander.

Please try to do what we are doing here its not complicated...

Pankraz76 · 2026-01-12T14:14:11Z

#18529

Pankraz76 changed the title ~~Issue #18470: Fix PMD violations~~ Issue #18470: Fix PMD violations #18470 Jan 6, 2026

Pankraz76 force-pushed the fix-pmd-fix-code branch from 9cf8697 to c38fa67 Compare January 6, 2026 15:19

Pankraz76 mentioned this pull request Jan 6, 2026

Pull #18529: Fix wrong test scope for PMD #18529

Merged

Pankraz76 force-pushed the fix-pmd-fix-code branch from c38fa67 to e56d65b Compare January 7, 2026 11:24

Pankraz76 marked this pull request as ready for review January 7, 2026 11:25

Pankraz76 commented Jan 7, 2026

View reviewed changes

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/AbstractAutomaticBean.java

Pankraz76 commented Jan 7, 2026

View reviewed changes

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/AbstractAutomaticBean.java Outdated

Pankraz76 force-pushed the fix-pmd-fix-code branch 4 times, most recently from dfdf6c8 to 011a8ba Compare January 7, 2026 12:52

Pankraz76 changed the title ~~Issue #18470: Fix PMD violations #18470~~ Pull #18530: Fix PMD violations #18470 Jan 8, 2026

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 8, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

d45e21e

Pankraz76 force-pushed the fix-pmd-fix-code branch from 011a8ba to d45e21e Compare January 8, 2026 10:51

romani requested changes Jan 9, 2026

View reviewed changes

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/DetailNodeTreeStringPrinter.java Outdated

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 9, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

3e89c4d

Pankraz76 force-pushed the fix-pmd-fix-code branch from d45e21e to 3e89c4d Compare January 9, 2026 11:23

Pankraz76 commented Jan 9, 2026

View reviewed changes

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/DetailNodeTreeStringPrinter.java Outdated

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 9, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

c226d02

Pankraz76 force-pushed the fix-pmd-fix-code branch from 3e89c4d to c226d02 Compare January 9, 2026 11:41

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 9, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

13ede56

Pankraz76 force-pushed the fix-pmd-fix-code branch from c226d02 to 13ede56 Compare January 9, 2026 12:24

Pankraz76 requested a review from romani January 9, 2026 12:25

Pankraz76 closed this Jan 9, 2026

Pankraz76 mentioned this pull request Jan 9, 2026

Issue #17487: Extend exceeding CI job #18577

Merged

Pankraz76 reopened this Jan 9, 2026

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 9, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

ec485e0

Pankraz76 force-pushed the fix-pmd-fix-code branch from 13ede56 to ec485e0 Compare January 9, 2026 15:24

romani requested changes Jan 10, 2026

View reviewed changes

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/DetailNodeTreeStringPrinter.java Outdated

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 10, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

f321292

Pankraz76 force-pushed the fix-pmd-fix-code branch from ec485e0 to f321292 Compare January 10, 2026 10:11

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 10, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

991be54

Pankraz76 force-pushed the fix-pmd-fix-code branch from f321292 to 991be54 Compare January 10, 2026 10:12

Pankraz76 requested a review from romani January 10, 2026 10:12

Pankraz76 commented Jan 10, 2026

View reviewed changes

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 10, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

979041e

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 10, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

6c75662

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 10, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

fe2af9c

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 10, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

f90079e

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 10, 2026

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

a08e0fe

Pankraz76 commented Jan 10, 2026

View reviewed changes

Pull checkstyle#18530: Fix PMD violations checkstyle#18470

da80ec0

Pankraz76 force-pushed the fix-pmd-fix-code branch from 991be54 to da80ec0 Compare January 10, 2026 11:59

Pankraz76 commented Jan 10, 2026

View reviewed changes

Pankraz76 mentioned this pull request Jan 10, 2026

MINOR: Add RemoveUnusedPrivateMethods #21165 #21168 #21149 apache/kafka#21269

Closed

Pankraz76 closed this Jan 12, 2026

Uh oh!

Conversation

Pankraz76 commented Jan 6, 2026 • edited by romani Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pankraz76 commented Jan 6, 2026

Uh oh!

Pankraz76 commented Jan 7, 2026

Uh oh!

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Pankraz76 commented Jan 9, 2026

Uh oh!

Pankraz76 commented Jan 9, 2026

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pankraz76 Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

romani commented Jan 11, 2026

Uh oh!

Pankraz76 commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pankraz76 commented Jan 11, 2026

Uh oh!

Pankraz76 commented Jan 11, 2026

Uh oh!

Pankraz76 commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Pankraz76 commented Jan 6, 2026 •

edited by romani

Loading

Pankraz76 Jan 10, 2026 •

edited

Loading

Pankraz76 commented Jan 11, 2026 •

edited

Loading